@ddaspit reviewed 12 of 12 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Enkidu93)

src/SIL.Machine/PunctuationAnalysis/QuotationMarkTabulator.cs line 83 at r1 (raw file):

            {
                ((int depth, QuotationMarkDirection direction), QuotationMarkCounts counts) = (kvp.Key, kvp.Value);
                if (!_quotationCountsByDepthAndDirection.ContainsKey((depth, direction)))

You should use TryGetValue here.

Reviewable status: 11 of 12 files reviewed, 1 unresolved discussion (waiting on @ddaspit)

src/SIL.Machine/PunctuationAnalysis/QuotationMarkTabulator.cs line 83 at r1 (raw file):

Done.

@ddaspit reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Enkidu93)

src/SIL.Machine/PunctuationAnalysis/QuotationMarkTabulator.cs line 87 at r2 (raw file):

                    _quotationCountsByDepthAndDirection[(depth, direction)] = new QuotationMarkCounts();
                }
                counts.CountFrom(counts);

I don't think this is right. Maybe you should use more explicit variable names here, such as thisCounts and otherCounts.

Reviewable status: 11 of 12 files reviewed, 1 unresolved discussion (waiting on @ddaspit)

src/SIL.Machine/PunctuationAnalysis/QuotationMarkTabulator.cs line 87 at r2 (raw file):

Oh my - that's pretty bad. That's what happens when you rush a change 😬. Sorry, done.

@ddaspit reviewed 1 of 1 files at r4, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Enkidu93)

src/SIL.Machine/PunctuationAnalysis/QuotationMarkTabulator.cs line 87 at r2 (raw file):

You aren't setting thisCounts when it doesn't already exist.

Reviewable status: 11 of 12 files reviewed, 1 unresolved discussion (waiting on @ddaspit)

src/SIL.Machine/PunctuationAnalysis/QuotationMarkTabulator.cs line 87 at r2 (raw file):

I see. Done. TryGetValue always confuses me. I always think I should be able to set thisCounts = new QuotationMarkCounts() when TryGetValue fails and that'll actually update the key in the dictionary and then I end up second-guessing myself 10 times. Hopefully, I've finally gotten it. It concerns me that no tests have failed in any of these broken iterations. I'll make sure I've done this correctly elsewhere.

@ddaspit reviewed 1 of 1 files at r5, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @Enkidu93)