Expose chapter numbers when finding best chapter strategies#369
Merged
Expose chapter numbers when finding best chapter strategies#369
Conversation
ddaspit
approved these changes
Dec 17, 2025
Contributor
ddaspit
left a comment
There was a problem hiding this comment.
@ddaspit reviewed 6 of 6 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @Enkidu93)
src/SIL.Machine/PunctuationAnalysis/Chapter.cs line 14 at r1 (raw file):
} public List<Verse> Verses { get; private set; }
It isn't a big deal, but private set; isn't necessary if the property is only ever set during construction.
4ce8412 to
1a02940
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #369 +/- ##
=======================================
Coverage 72.60% 72.60%
=======================================
Files 423 423
Lines 35973 35975 +2
Branches 4965 4965
=======================================
+ Hits 26117 26119 +2
Misses 8758 8758
Partials 1098 1098 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Enkidu93
added a commit
to sillsdev/machine.py
that referenced
this pull request
Jan 13, 2026
Enkidu93
added a commit
to sillsdev/machine.py
that referenced
this pull request
Jan 21, 2026
Enkidu93
added a commit
to sillsdev/machine.py
that referenced
this pull request
Jan 22, 2026
* Update key terms handling to support silnlp features * Port sillsdev/machine#362 * Remove non-pt localizations from pt xml (to match Machine C#) * Add key terms as partial words * Port 'Expose chapter numbers' sillsdev/machine#369 * Add content type property to rows
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Needed for sillsdev/serval#832
This change is