Check for Paratext project files case-insensitively#371
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #371 +/- ##
=======================================
Coverage 72.60% 72.61%
=======================================
Files 423 423
Lines 35975 35992 +17
Branches 4965 4965
=======================================
+ Hits 26119 26134 +15
- Misses 8758 8760 +2
Partials 1098 1098 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ddaspit
left a comment
There was a problem hiding this comment.
@ddaspit partially reviewed 3 files and all commit messages, and made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Enkidu93).
src/SIL.Machine/Corpora/FileParatextProjectFileHandler.cs line 18 at r1 (raw file):
{ return Directory .EnumerateFiles(_projectDir)
I wonder if the overload of this method that takes a pattern and options would be better. Would Directory.EnumerateFiles(_projectDir, fileName, new EnumerationOptions { MatchCasing = false }).Any() work?
|
Previously, ddaspit (Damien Daspit) wrote…
I tried that and it seemed like that overload does not exist on my machine. Maybe something is wrong with my .NET set-up/version? Does it work on your machine? |
ddaspit
left a comment
There was a problem hiding this comment.
@ddaspit made 2 comments and resolved 1 discussion.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @Enkidu93).
src/SIL.Machine/Corpora/FileParatextProjectFileHandler.cs line 18 at r1 (raw file):
Previously, Enkidu93 (Eli C. Lowry) wrote…
I tried that and it seemed like that overload does not exist on my machine. Maybe something is wrong with my .NET set-up/version? Does it work on your machine?
Oh, never mind. It is only available in .NET Standard 2.1. We are using 2.0.
Fixes #366.
I was hoping there was a more straightforward way to do this through the C# libraries, but I didn't see anything. Let me know if I've just missed it.
This change is