@ddaspit reviewed 28 of 28 files at r1, all commit messages.
Reviewable status: all files reviewed, 6 unresolved discussions (waiting on @Enkidu93)

machine/corpora/usfm_versification_error_detector.py line 114 at r1 (raw file):

class UsfmVersificationErrorDetector(UsfmParserHandler):

You are missing types in this class.

tests/testutils/memory_paratext_project_versification_error_detector.py line 4 at r1 (raw file):

from machine.corpora import ParatextProjectSettings
from machine.corpora.paratext_project_versification_error_detector import ParatextProjectVersificationErrorDetector

You should import from machine.corpora.

machine/corpora/zip_paratext_project_file_handler.py line 39 at r1 (raw file):

                stylesheet_temp_fd, stylesheet_temp_path = mkstemp()
                with (
                    self.open(file_name) as source,  # type: ignore

I would prefer that you cast rather than ignore the error. It makes the intent more explicit.

tests/testutils/memory_paratext_project_file_handler.py line 4 at r1 (raw file):

from typing import BinaryIO, Dict, Optional

from machine.corpora.paratext_project_file_handler import ParatextProjectFileHandler

You should import from machine.corpora and machine.scripture.

tests/corpora/test_usfm_verisifcation_error_detector.py line 9 at r1 (raw file):

)

from machine.corpora.paratext_project_settings import ParatextProjectSettings

You should import from machine.corpora and machine.scripture.

tests/corpora/test_usfm_manual.py line 22 at r1 (raw file):

    UpdateUsfmTextBehavior,
)
from machine.corpora.zip_paratext_project_versification_detector import ZipParatextProjectVersificationErrorDetector

You should import from machine.corpora.

Reviewable status: all files reviewed, 6 unresolved discussions (waiting on @ddaspit)

machine/corpora/usfm_versification_error_detector.py line 114 at r1 (raw file):

Do you mean type hints? Done - if I'm understanding correctly.

machine/corpora/zip_paratext_project_file_handler.py line 39 at r1 (raw file):

OK, done.

tests/corpora/test_usfm_manual.py line 22 at r1 (raw file):

Done. I wonder if there's a way to fix the auto-importing. I guess it may have been that I hadn't added these classes to the __init__.py 🤔.

tests/corpora/test_usfm_verisifcation_error_detector.py line 9 at r1 (raw file):

Done.

tests/testutils/memory_paratext_project_file_handler.py line 4 at r1 (raw file):

Done.

tests/testutils/memory_paratext_project_versification_error_detector.py line 4 at r1 (raw file):

Done.

@ddaspit reviewed 7 of 7 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Enkidu93)

machine/corpora/usfm_versification_error_detector.py line 114 at r1 (raw file):

Yes, that is what I meant. You forgot type hints for the method parameters.

tests/corpora/test_usfm_manual.py line 22 at r1 (raw file):

It is annoying. I like to interact with the classes in unit tests the same way that a calling application would, so that we can ensure that everything is exported properly.

Reviewable status: 27 of 28 files reviewed, 1 unresolved discussion (waiting on @ddaspit)

machine/corpora/usfm_versification_error_detector.py line 114 at r1 (raw file):

Oh, I see - sorry, yep! Surprises me that the type hints weren't carried over when VS Code suggested the method signatures from the base class 🤔. Maybe there's a setting for that too haha! Done.

@ddaspit reviewed 1 of 1 files at r4, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @Enkidu93)

machine/corpora/usfm_versification_error_detector.py line 114 at r1 (raw file):

I noticed that it leaves out type hints.

@ddaspit reviewed 4 of 4 files at r5, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @Enkidu93)