Skip to content

chore(config): clean up bun, turbo, and next.js config#3788

Merged
waleedlatif1 merged 2 commits intostagingfrom
waleedlatif1/bun-config-review
Mar 26, 2026
Merged

chore(config): clean up bun, turbo, and next.js config#3788
waleedlatif1 merged 2 commits intostagingfrom
waleedlatif1/bun-config-review

Conversation

@waleedlatif1
Copy link
Collaborator

Summary

  • Clean up bunfig.toml: remove dead config (test, build, debug) and redundant defaults
  • Bump bun from 1.3.10 to 1.3.11
  • Add sideEffects declarations to @sim/logger, @sim/testing, @sim/tsconfig for better tree-shaking
  • Enable AVIF image format in next.config.ts
  • Fix stale turbo.json $schema URL

Type of Change

  • Maintenance/cleanup

Testing

Tested manually — bun install succeeds, lint passes

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@cursor
Copy link

cursor bot commented Mar 26, 2026

PR Summary

Low Risk
Mostly version bumps and configuration cleanups; the main risk is CI/Docker build behavior changing due to the Bun upgrade and bundling/tree-shaking metadata updates.

Overview
Updates the project’s Bun version from 1.3.10 to 1.3.11 across Docker images, the devcontainer, GitHub Actions workflows, and package.json to keep local and CI environments in sync.

Cleans up bunfig.toml by removing unused/redundant settings, updates turbo.json to the current schema URL, and tweaks Next.js image handling to prefer modern formats (adds image/avif).

Adds sideEffects metadata to internal packages (notably @sim/logger, @sim/testing, @sim/tsconfig) to improve bundler tree-shaking while preserving intended setup-file side effects.

Written by Cursor Bugbot for commit 05d5ce8. Configure here.

@vercel
Copy link

vercel bot commented Mar 26, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
docs Ready Ready Preview, Comment Mar 26, 2026 8:01pm

Request Review

@waleedlatif1 waleedlatif1 force-pushed the waleedlatif1/bun-config-review branch from f165148 to db3a79d Compare March 26, 2026 19:55
@greptile-apps
Copy link
Contributor

greptile-apps bot commented Mar 26, 2026

Greptile Summary

This is a straightforward maintenance PR that cleans up configuration across the monorepo: bumps Bun from 1.3.10 → 1.3.11 consistently everywhere, strips dead and redundant entries from bunfig.toml, adds sideEffects declarations to three internal packages for better tree-shaking, enables AVIF image optimization in Next.js, and fixes a stale version-pinned Turbo schema URL.\n\nKey changes:\n- Bun 1.3.11 bump applied uniformly across all Dockerfiles, GitHub Actions workflows, and package.json\n- bunfig.toml reduced to only the two blocks that actually do work ([install] exact and [run] env); removed [test], [build], [debug] sections that were effectively no-ops given the project uses Vitest (not bun test) and Next.js/Turbopack (not bun build)\n- sideEffects: false on @sim/logger and @sim/tsconfig is safe — both packages are pure exports with no module-level initialization; @sim/testing correctly carves out ./src/setup/* as effectful\n- formats: ['image/avif', 'image/webp'] in Next.js images config is well-supported since sharp is already tracked in outputFileTracingIncludes\n- turbo.json schema now points to the canonical https://turbo.build/schema.json rather than a pinned dev subdomain URL

Confidence Score: 5/5

Safe to merge — all changes are configuration cleanup with no behavioral impact on application logic.

Every change is either a mechanical version bump (Bun 1.3.11 applied uniformly to 9 files), removal of confirmed-dead config, or a well-understood config addition (AVIF, sideEffects). The logger package's sideEffects: false was verified against its source — only pure exports, no module-level side effects. No functional code was touched.

No files require special attention.

Important Files Changed

Filename Overview
bunfig.toml Removed dead/redundant config sections ([test], [build], [debug]) and default-matching options (registry, cache, strict, frozen, workspaces); only essential [install] and [run] settings remain.
apps/sim/next.config.ts Added formats: ['image/avif', 'image/webp'] to Next.js image config; sharp is already tracked in outputFileTracingIncludes so AVIF encoding is supported.
packages/logger/package.json Added sideEffects: false; confirmed safe — the package only exports pure functions/classes/enums with no module-level initialization code.
packages/testing/package.json Added sideEffects: ["./src/setup/*"]; correctly exempts setup files from tree-shaking while allowing it for factories, builders, mocks, and assertions.
packages/tsconfig/package.json Added sideEffects: false; safe since this package only contains JSON/TypeScript configuration files with no executable side effects.
turbo.json Updated $schema from a version-pinned URL (v2-8-13.turborepo.dev) to the canonical https://turbo.build/schema.json; affects IDE schema validation only, not build behavior.
package.json Bumped packageManager field from [email protected] to [email protected], consistent with all other version references updated in this PR.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[PR Changes] --> B[Bun 1.3.10 → 1.3.11]
    A --> C[bunfig.toml cleanup]
    A --> D[sideEffects declarations]
    A --> E[next.config.ts]
    A --> F[turbo.json schema URL]

    B --> B1[package.json packageManager]
    B --> B2[9 CI/Docker files updated]

    C --> C1[Removed dead sections\n test / build / debug]
    C --> C2[Removed redundant defaults\n registry / cache / strict / frozen / workspaces]

    D --> D1["@sim/logger: false\npure exports only"]
    D --> D2["@sim/testing: ./src/setup/*\nsetup files kept effectful"]
    D --> D3["@sim/tsconfig: false\nconfig files only"]

    E --> E1["Added AVIF format support\n image/avif, image/webp"]

    F --> F1["Canonical URL\nhttps://turbo.build/schema.json"]
Loading

Reviews (2): Last reviewed commit: "chore(ci): bump bun to 1.3.11 in dockerf..." | Re-trigger Greptile

@waleedlatif1
Copy link
Collaborator Author

@greptile

@waleedlatif1
Copy link
Collaborator Author

@cursor review

Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Bugbot reviewed your changes and found no new issues!

Comment @cursor review or bugbot run to trigger another review on this PR

@waleedlatif1 waleedlatif1 merged commit 8a481b6 into staging Mar 26, 2026
12 checks passed
@waleedlatif1 waleedlatif1 deleted the waleedlatif1/bun-config-review branch March 26, 2026 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant