Skip to content

fix(knowledge): prevent navigation on context menu actions and widen tags modal #4015

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
waleedlatif1 merged 4 commits into from
Apr 7, 2026
+35 −13
Merged

fix(knowledge): prevent navigation on context menu actions and widen tags modal #4015

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5343bc9
fix(knowledge): prevent navigation on context menu actions and widen …
waleedlatif1 Apr 7, 2026
dea71d1
fix(knowledge): guard onCopyId against navigation and use setTimeout …
waleedlatif1 Apr 7, 2026
7673726
refactor(knowledge): extract withActionGuard helper to deduplicate co…
waleedlatif1 Apr 7, 2026
2a82159
fix(knowledge): wrap withActionGuard callback in try/finally to preve…
waleedlatif1 Apr 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...aceId]/knowledge/[id]/[documentId]/components/document-tags-modal/document-tags-modal.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -383,7 +383,7 @@ export function DocumentTagsModal({

return (
<Modal open={open} onOpenChange={handleClose}>
<ModalContent size='sm'>
<ModalContent size='md'>
<ModalHeader>
<div className='flex items-center justify-between'>
<span>Document Tags</span>
Expand Down
2 changes: 1 addition & 1 deletion ...app/workspace/[workspaceId]/knowledge/[id]/components/base-tags-modal/base-tags-modal.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -261,7 +261,7 @@ export function BaseTagsModal({ open, onOpenChange, knowledgeBaseId }: BaseTagsM
return (
<>
<Modal open={open} onOpenChange={handleClose}>
<ModalContent size='sm'>
<ModalContent size='md'>
<ModalHeader>
<div className='flex items-center justify-between'>
<span>Tags</span>
Expand Down
44 changes: 33 additions & 11 deletions apps/sim/app/workspace/[workspaceId]/knowledge/components/base-card/base-card.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
'use client'

import { useCallback, useState } from 'react'
import { useCallback, useRef, useState } from 'react'
import { useParams, useRouter } from 'next/navigation'
import { Badge, DocumentAttachment, Tooltip } from '@/components/emcn'
import { formatAbsoluteDate, formatRelativeTime } from '@/lib/core/utils/formatting'
Expand Down Expand Up @@ -101,6 +101,23 @@ export function BaseCard({
const [isTagsModalOpen, setIsTagsModalOpen] = useState(false)
const [isDeleting, setIsDeleting] = useState(false)

/**
* Guards against context menu actions triggering card navigation.
* The card's onClick fires synchronously during the click event bubble phase,
* so the ref is checked before the setTimeout-0 callback resets it.
*/
const actionTakenRef = useRef(false)
const withActionGuard = useCallback((fn: () => void) => {
actionTakenRef.current = true
try {
fn()
} finally {
setTimeout(() => {
actionTakenRef.current = false
}, 0)
}
}, [])

const searchParams = new URLSearchParams({
kbName: title,
})
Expand All @@ -110,7 +127,7 @@ export function BaseCard({

const handleClick = useCallback(
(e: React.MouseEvent) => {
if (isContextMenuOpen) {
if (isContextMenuOpen || actionTakenRef.current) {
e.preventDefault()
return
}
Expand All @@ -130,20 +147,25 @@ export function BaseCard({
)

const handleOpenInNewTab = useCallback(() => {
window.open(href, '_blank')
}, [href])
withActionGuard(() => window.open(href, '_blank'))
}, [href, withActionGuard])

const handleViewTags = useCallback(() => {
setIsTagsModalOpen(true)
}, [])
withActionGuard(() => setIsTagsModalOpen(true))
}, [withActionGuard])

const handleEdit = useCallback(() => {
setIsEditModalOpen(true)
}, [])
withActionGuard(() => setIsEditModalOpen(true))
}, [withActionGuard])

const handleDelete = useCallback(() => {
setIsDeleteModalOpen(true)
}, [])
withActionGuard(() => setIsDeleteModalOpen(true))
}, [withActionGuard])

const handleCopyId = useCallback(() => {
if (!id) return
withActionGuard(() => navigator.clipboard.writeText(id))
}, [id, withActionGuard])

const handleConfirmDelete = useCallback(async () => {
if (!id || !onDelete) return
Expand Down Expand Up @@ -240,7 +262,7 @@ export function BaseCard({
onClose={closeContextMenu}
onOpenInNewTab={handleOpenInNewTab}
onViewTags={handleViewTags}
onCopyId={id ? () => navigator.clipboard.writeText(id) : undefined}
onCopyId={id ? handleCopyId : undefined}
onEdit={handleEdit}
onDelete={handleDelete}
showOpenInNewTab={true}
Expand Down
Loading