fix(agent): include model in structured response output#4092
fix(agent): include model in structured response output#4092waleedlatif1 merged 2 commits intostagingfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
PR SummaryLow Risk Overview Tests were updated to assert Reviewed by Cursor Bugbot for commit b8251a4. Configure here. |
Greptile SummaryThis PR fixes a bug where the Confidence Score: 5/5Safe to merge — minimal, targeted bug fix with a matching test covering the previously untested code path. The change is a single-field relocation with no behavioral regressions on the standard path and a clear fix for the structured response path. No P0 or P1 findings identified. No files require special attention. Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[Agent Execute] --> B{responseFormat set?}
B -- No --> C[processStandardResponse]
B -- Yes --> D[processStructuredResponse]
C --> E["return { content, ...createResponseMetadata }"]
D --> F{Valid JSON?}
F -- Yes --> G["return { ...extractedJson, ...createResponseMetadata }"]
F -- No --> H[Fallback to processStandardResponse]
E --> I["createResponseMetadata includes model ✓"]
G --> I
H --> I
Reviews (2): Last reviewed commit: "fix(agent): update test expectation for ..." | Re-trigger Greptile |
|
@greptile |
|
@cursor review |
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit b8251a4. Configure here.
Summary
modelintocreateResponseMetadataso it's included in both standard and structured (custom response format) agent outputsagent.modelwas missing when a custom response format was providedType of Change
Testing
Tested manually
Checklist