-
Notifications
You must be signed in to change notification settings - Fork 3.5k
v0.6.35: additional jira fields, HITL docs, logs cleanup efficiency #4093
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
171485d
4074109
476669f
04c1f8e
3efbd1d
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| { | ||
| "pages": [ | ||
| "listPausedExecutions", | ||
| "getPausedExecution", | ||
| "getPausedExecutionByResumePath", | ||
| "getPauseContext", | ||
| "resumeExecution" | ||
| ] | ||
| } |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -50,13 +50,36 @@ export function parseJsmErrorMessage( | |
| ): string { | ||
| try { | ||
| const errorData = JSON.parse(errorText) | ||
| // JSM Service Desk: singular errorMessage | ||
| if (errorData.errorMessage) { | ||
| return `JSM Forms API error: ${errorData.errorMessage}` | ||
| return errorData.errorMessage | ||
| } | ||
| // Jira Platform: errorMessages array | ||
| if (Array.isArray(errorData.errorMessages) && errorData.errorMessages.length > 0) { | ||
| return errorData.errorMessages.join(', ') | ||
| } | ||
| // Confluence v2 / Forms API: RFC 7807 errors array | ||
| if (Array.isArray(errorData.errors) && errorData.errors.length > 0) { | ||
| const err = errorData.errors[0] | ||
| if (err?.title) { | ||
| return err.detail ? `${err.title}: ${err.detail}` : err.title | ||
| } | ||
| } | ||
| // Jira Platform field-level errors object | ||
| if (errorData.errors && !Array.isArray(errorData.errors)) { | ||
| const fieldErrors = Object.entries(errorData.errors) | ||
| .map(([field, msg]) => `${field}: ${msg}`) | ||
| .join(', ') | ||
| if (fieldErrors) return fieldErrors | ||
| } | ||
| // Generic message fallback | ||
| if (errorData.message) { | ||
|
Comment on lines
+53
to
+76
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
The added Context Used: Global coding standards that apply to all files (source) |
||
| return errorData.message | ||
| } | ||
| } catch { | ||
| if (errorText) { | ||
| return `JSM Forms API error: ${errorText}` | ||
| return errorText | ||
| } | ||
| } | ||
| return `JSM Forms API error: ${status} ${statusText}` | ||
| return `${status} ${statusText}` | ||
| } | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Metadata
modelfield silently overwrites structured response dataLow Severity
Moving
modelintocreateResponseMetadatameans it now gets spread over user-defined structured output inprocessStructuredResponse. Since metadata is spread afterextractedJson, a user whose response schema includes amodelfield (e.g., product model, car model) will have that value silently overwritten by the provider's model identifier. Unlike the other metadata keys (tokens,toolCalls,providerTiming,cost),modelis a common real-world field name, making collision more likely.Additional Locations (1)
apps/sim/executor/handlers/agent/agent-handler.ts#L1051-L1055Reviewed by Cursor Bugbot for commit 3efbd1d. Configure here.