Skip to content

Fix #254 Add built-in tokens_revoked/app_uninstalled event handlers#289

Merged
seratch merged 2 commits intoslackapi:mainfrom
seratch:issue-254-token-revocation
Apr 16, 2021
Merged

Fix #254 Add built-in tokens_revoked/app_uninstalled event handlers#289
seratch merged 2 commits intoslackapi:mainfrom
seratch:issue-254-token-revocation

Conversation

@seratch
Copy link
Copy Markdown
Contributor

@seratch seratch commented Apr 12, 2021

This pull request resolves #254 - refer to the issue for details.

Category (place an x in each of the [ ])

  • slack_bolt.App and/or its core components
  • slack_bolt.async_app.AsyncApp and/or its core components
  • Adapters in slack_bolt.adapter
  • Document pages under /docs
  • Others

Requirements (place an x in each [ ])

Please read the Contributing guidelines and Code of Conduct before creating this issue or pull request. By submitting, you are agreeing to those rules.

  • I've read and understood the Contributing Guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've run ./scripts/install_all_and_run_tests.sh after making the changes.

@seratch seratch added this to the 1.5.0 milestone Apr 12, 2021
@seratch seratch requested review from mwbrooks and stevengill April 12, 2021 02:51
@seratch seratch self-assigned this Apr 12, 2021
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 12, 2021 •
edited
Loading

Codecov Report

Merging #289 (5e2c3e0) into main (8babac6) will increase coverage by 0.10%.
The diff coverage is 100.00%.

❗ Current head 5e2c3e0 differs from pull request most recent head 2ab87ee. Consider uploading reports for the commit 2ab87ee to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main     #289      +/-   ##
==========================================
+ Coverage   91.35%   91.46%   +0.10%     
==========================================
  Files         164      166       +2     
  Lines        5135     5200      +65     
==========================================
+ Hits         4691     4756      +65     
  Misses        444      444
Impacted Files Coverage Δ
slack_bolt/app/app.py 87.10% <100.00%> (+0.48%) ⬆️
slack_bolt/app/async_app.py 94.23% <100.00%> (+0.24%) ⬆️
slack_bolt/listener/async_builtins.py 100.00% <100.00%> (ø)
slack_bolt/listener/builtins.py 100.00% <100.00%> (ø)
slack_bolt/logger/messages.py 87.27% <100.00%> (+0.48%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8babac6...2ab87ee. Read the comment docs.

mwbrooks
mwbrooks approved these changes Apr 16, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@mwbrooks mwbrooks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a really nice addition. I think it fits very well into the Bolt framework and ideal for anyone using Bolt's built-in OAuth store.

If it's well received, we should add it to Bolt-JS as well!

@seratch
Copy link
Copy Markdown
Contributor Author

seratch commented Apr 16, 2021

If it's well received, we should add it to Bolt-JS as well!

Yes, I am definitely going to do this next 💪

@seratch seratch merged commit 8786783 into slackapi:main Apr 16, 2021
@seratch seratch deleted the issue-254-token-revocation branch April 16, 2021 05:01
@seratch seratch mentioned this pull request Jul 17, 2021
Closed
@seratch seratch mentioned this pull request Nov 8, 2021
Open
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mwbrooks mwbrooks mwbrooks approved these changes

@stevengill stevengill Awaiting requested review from stevengill

Assignees

@seratch seratch

Labels

area:async area:sync enhancement New feature or request

Projects

None yet

Milestone

1.5.0

Development

Successfully merging this pull request may close these issues.

Add built-in tokens_revoked/app_uninstalled event handlers

2 participants

@seratch @mwbrooks