Fall back to getallheaders() when available#1867
Merged
akrabat merged 3 commits intoslimphp:3.xfrom May 19, 2016
tuupola:getallheaders-fallback
Merged
Fall back to getallheaders() when available#1867akrabat merged 3 commits intoslimphp:3.xfrom tuupola:getallheaders-fallback
akrabat merged 3 commits intoslimphp:3.xfrom
tuupola:getallheaders-fallback
Conversation
Tries to get Authorization header from getallheaders() if it is available and HTTP_AUTHORIZATION does not already exist.
| * | ||
| * @return Environment | ||
| */ | ||
|
|
Member
There was a problem hiding this comment.
I would prefer a more specific method name.
akrabat
added a commit
that referenced
this pull request
May 19, 2016
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When sending something else than valid
Authorization: Basicheader PHP will not set theHTTP_AUTHORIZATIONenvironment. Because of this theAuthorizationheader is not available via$request->getHeader("Authorization"). See #1784, #1616.This is problematic when you are using
Authorization: Beareror something similar. Usual workaround is to add the following rewrite rule.RewriteRule .* - [env=HTTP_AUTHORIZATION:%{HTTP:Authorization}]However even without the workaround, the header is however available via
getallheaders(). This PR adds a fallback call togetallheaders()when it is available andHTTP_AUTHORIZATIONis not set.