Skip to content

Testing Router Methods#1882

Merged
akrabat merged 1 commit intoslimphp:3.xfrom
danielgsims:router-test-alt
May 19, 2016
Merged

Testing Router Methods#1882
akrabat merged 1 commit intoslimphp:3.xfrom
danielgsims:router-test-alt

Conversation

@danielgsims
Copy link
Copy Markdown

  • Testing sad path from route lookup
  • Testing that urlFor proxies pathFor but triggers warning

  * Testing sad path from route lookup
  * Testing that urlFor proxies pathFor but triggers warning
@coveralls
Copy link
Copy Markdown

Coverage Status

Coverage increased (+0.2%) to 93.789% when pulling 2900788 on danielgsims:router-test-alt into 794073a on slimphp:3.x.

@danielgsims
Copy link
Copy Markdown
Author

@dopesong - Writing the error handler this way helped us get around the weird error-conversion issue with the HVVM build on travis too

@dopesong
Copy link
Copy Markdown
Contributor

Glad to see that ;)

@akrabat akrabat added this to the 3.5.0 milestone May 19, 2016
@akrabat akrabat merged commit 2900788 into slimphp:3.x May 19, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants