Skip to content

Assignment two#2

Open
smodi23 wants to merge 5 commits intomainfrom
assignment-two
Open

Assignment two#2
smodi23 wants to merge 5 commits intomainfrom
assignment-two

Conversation

@smodi23
Copy link
Copy Markdown
Owner

@smodi23 smodi23 commented May 10, 2025

What changes are you trying to make? (e.g. Adding or removing code, refactoring existing code, adding reports)

What did you learn from the changes you have made?

Was there another approach you were thinking about making? If so, what approach(es) were you thinking of?

Were there any challenges? If so, what issue(s) did you face? How did you overcome it?

How were these changes tested?

A reference to a related issue in your repository (if applicable)

Checklist

  • I can confirm that my changes are working as intended

Copy link
Copy Markdown

@anjali-deshpande-hub anjali-deshpande-hub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Please make the following review changes:

  1. Replace the hardcoded absolute paths to relative paths so that a Learning support can run the code successfully as well. For example: change r"/users/sahil/python/05_src/data/assignment_2_data/inflammation_01.csv" to r"../../05_src/data/assignment_2_data/inflammation_01.csv"

  2. Changes to assignment_1.ipynb should not be included in this pull request.
    Please refer to following thread of slack https://uoft-dsi-certificates.slack.com/archives/C08JWD6RRU3/p1747084222526419 to fix this.

Copy link
Copy Markdown

@anjali-deshpande-hub anjali-deshpande-hub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review comment 1 is not The path is incorrect. That is why you get an error. 'python' should not be in the path. Please correct. Screenshot 2025-05-14 215546.
Review comment 2 is fixed.

Copy link
Copy Markdown

@anjali-deshpande-hub anjali-deshpande-hub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All fixed. Well done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants