Support copy of some binary files#354
Merged
hugtalbot merged 4 commits intosofa-framework:masterfrom Jul 5, 2023
Merged
Conversation
Contributor
|
Is there any reason why not to use copy all the time ? |
Contributor
Author
|
|
Contributor
|
I know, but do the files given as parameter in configure_file need that ? Why no just having two set of files, the ones that contains cmake template token from the others ? |
This reverts commit 55f74a4.
damienmarchal
pushed a commit
that referenced
this pull request
Sep 13, 2024
* Support copy of some binary files * Revert "Support copy of some binary files" This reverts commit 55f74a4. * Try to copy without configure * Fix
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The command
configure_filewith attribute@ONLYdoes not make sense for binary files. Actually, it corrupts them when copying them. So they have to be handled differently.I don' t know how to detect that a file is binary or not, so I adopted a strategy where I checked if the file extension matches a list of known extensions. This is not generic...
For the record, we have binary files in Python modules in SoftRobots. It corresponds to meshes. The Finger for example