Skip to content

Fix BaseMeshTopology inheritance #385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fredroy merged 1 commit into from
Jan 9, 2024
+8 −4
Merged

Fix BaseMeshTopology inheritance #385

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion bindings/Sofa/src/SofaPython3/Sofa/Core/Binding_BaseMeshTopology.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ using namespace sofa::core::topology;
namespace sofapython3 {

void moduleAddBaseMeshTopology(py::module& m) {
py::class_<BaseMeshTopology, Base, py_shared_ptr<BaseMeshTopology>> c (m, "BaseMeshTopology");
py::class_<BaseMeshTopology, Topology, py_shared_ptr<BaseMeshTopology>> c (m, "BaseMeshTopology");

/// register the BaseMeshTopology binding in the downcasting subsystem
PythonFactory::registerType<BaseMeshTopology>([](sofa::core::objectmodel::Base* object)
Expand Down
2 changes: 1 addition & 1 deletion bindings/Sofa/src/SofaPython3/Sofa/Core/Binding_Topology.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ using namespace sofa::core::topology;
namespace sofapython3 {

void moduleAddTopology(py::module& m) {
py::class_<Topology, Base, py_shared_ptr<Topology>> c (m, "Topology");
py::class_<Topology, BaseObject, py_shared_ptr<Topology>> c (m, "Topology");
}

} // namespace sofapython3
8 changes: 6 additions & 2 deletions bindings/Sofa/tests/Core/BaseObject.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,8 +64,12 @@ def test_getName(self):

def test_getCategories(self):
root = create_scene("rootNode")
c = root.addObject("MechanicalObject", name="t")
self.assertEqual(c.getCategories(), ["MechanicalState"])

mecha = root.addObject("MechanicalObject", name="t")
self.assertEqual(mecha.getCategories(), ["MechanicalState"])

topo = root.addObject("MeshTopology", name="topology")
self.assertEqual(topo.getCategories(), ["Topology"])

def test_getPathName(self):
root = create_scene("rootNode")
Expand Down