Replace deprecated imp by importlib#411
Merged
bakpaul merged 1 commit intosofa-framework:masterfrom May 8, 2024
Merged
Conversation
Contributor
|
@damienmarchal, @olivier-roussel, @hugtalbot can we merge this ? Thanks. |
olivier-roussel
approved these changes
Apr 4, 2024
adagolodjo
approved these changes
Apr 5, 2024
Contributor
|
Yes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://docs.python.org/dev/whatsnew/3.12.html#imp
Imp has been deprecated since Python3 3.4 (!) and has been removed in 3.12.1
Hitting first macOS users because homebrew recently updated their version.
More context : https://discuss.python.org/t/how-do-i-migrate-from-imp/27885/13
livecoding.pyis called in PythonEnvironment, so it is throwing an error every time.This PR replaces imp by importlib.
I just tested by calling directly the file (and using the onReimpAFile(file).
There is no test at all currently and this onReimpAFile() function is only used for prefab.
Fix partially sofa-framework/sofa#4624