Skip to content

#1302 fix lots of whitespace slcli vs create-options#1310

Merged
allmightyspiff merged 5 commits intosoftlayer:masterfrom
ATGE:issues1302
Jul 31, 2020
Merged

#1302 fix lots of whitespace slcli vs create-options#1310
allmightyspiff merged 5 commits intosoftlayer:masterfrom
ATGE:issues1302

Conversation

@ATGE
Copy link
Copy Markdown
Contributor

@ATGE ATGE commented Jul 24, 2020

No description provided.

@allmightyspiff allmightyspiff self-requested a review July 24, 2020 22:36
@allmightyspiff allmightyspiff linked an issue Jul 24, 2020 that may be closed by this pull request
Lots of whitespace / newlines in slcli vs create-options #1302
Closed
allmightyspiff
allmightyspiff requested changes Jul 24, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@allmightyspiff allmightyspiff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you fix the VirtTests.test_create_options test. I'm not sure why it only fails in 3.5, but I think a quick fix would have it test only for certain bits of data in the result. Not making sure the ENTIRE result matches, which will break any time we make slight changes like this.

@allmightyspiff
Copy link
Copy Markdown
Member

allmightyspiff commented Jul 24, 2020

Looks good, but the OS table still has some funky characters in it.

:......................................:
:          Operating Systems           :
:............:.........................:
: os         : value                   :
:............:.........................:
            :: CENTOS_5_64
            :: CENTOS_6_64
            :: CENTOS_7_64
          :  : CENTOS_LATEST
:            : CENTOS_LATEST_64        :
        :NUX : CLOUDLINUX_5_64
      :      : CLOUDLINUX_LATEST
:            : CLOUDLINUX_LATEST_64    :
      :S     : COREOS_CURRENT_64
          :  : COREOS_LATEST
:            : COREOS_LATEST_64        :
            :: DEBIAN_6_64
            :: DEBIAN_8_64
            :: DEBIAN_9_64
          :  : DEBIAN_LATEST
:            : DEBIAN_LATEST_64        :
            :: REDHAT_5_64
            :: REDHAT_6_64
            :: REDHAT_7_64
          :  : REDHAT_LATEST
:            : REDHAT_LATEST_64        :
           : : UBUNTU_12_64
           : : UBUNTU_16_64
           : : UBUNTU_18_64
          :  : UBUNTU_LATEST
:            : UBUNTU_LATEST_64        :
        :E   : VYATTACE_6.5_64
        :    : VYATTACE_6.6_64
        :    : VYATTACE_LATEST
:            : VYATTACE_LATEST_64      :
   :N        : WIN_2003-DC-SP2-1_32
   :         : WIN_2003-DC-SP2-1_64
  :          : WIN_2003-ENT-SP2-5_32
  :          : WIN_2003-ENT-SP2-5_64
  :          : WIN_2003-STD-SP2-5_32
  :          : WIN_2003-STD-SP2-5_64
 :           : WIN_2008-STD-R2-SP1_64
    :        : WIN_2008-STD-SP2_32
    :        : WIN_2008-STD-SP2_64
     :       : WIN_2012-STD-R2_64
        :    : WIN_2012-STD_64
        :    : WIN_2016-STD_64
        :    : WIN_2019-STD_64
             : WIN_LATEST
          :  : WIN_LATEST_32
:            : WIN_LATEST_64           :
:............:.........................:

allmightyspiff
allmightyspiff requested changes Jul 24, 2020
View reviewed changes
allmightyspiff
allmightyspiff approved these changes Jul 31, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@allmightyspiff allmightyspiff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks 👍

@allmightyspiff allmightyspiff merged commit c623829 into softlayer:master Jul 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@allmightyspiff allmightyspiff allmightyspiff approved these changes

Assignees

@ATGE ATGE

Labels

Bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Lots of whitespace / newlines in slcli vs create-options

2 participants

@ATGE @allmightyspiff