Skip to content

The SoftLayer_Ticket::addAttachedFile method fails when tried to attach images #506 #507

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
gordonjm wants to merge 3 commits into from
Closed

The SoftLayer_Ticket::addAttachedFile method fails when tried to attach images #506 #507

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e0b1c76
Fixed Python 2 base64 encoding problem (i.e. fixed "No authentication…
gordonjm Mar 20, 2015
7822b24
Fixed typos in previous commit.
gordonjm Mar 20, 2015
dc524a3
Code review fix.
gordonjm Mar 20, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions SoftLayer/transports.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,13 +8,17 @@
from SoftLayer import exceptions
from SoftLayer import utils

import base64

import importlib
import json
import logging
import time

import requests

import sys

LOGGER = logging.getLogger(__name__)
# transports.Request does have a lot of instance attributes. :(
# pylint: disable=too-many-instance-attributes
Expand Down Expand Up @@ -108,6 +112,15 @@ def __call__(self, request):

largs.insert(0, {'headers': headers})

# In Python 2 xmlrpc_client.dumps(...) does not
# automatically perform base64 encoding.
Copy link
Member

@Neetuj Neetuj Mar 20, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to tackle too many local variable restriction of landscape .. you could may be direclty compare
if sys.version_info[0] <3

not sure who/why the limit of 15 local variables is/was enforced

if sys.version_info[0] < 3:
for index, dictionary in enumerate(largs):
if 'data' in dictionary:
data = dictionary['data']
largs[index]['data'] = base64.b64encode(data)
break

url = '/'.join([request.endpoint, request.service])
payload = utils.xmlrpc_client.dumps(tuple(largs),
methodname=request.method,
Expand Down