Skip to content

V3.0: Removing explicit receiver for private method calls in VirtualServerUpgradeOrder(verify, place_order!)#90

Merged
SLsthompson merged 2 commits intosoftlayer:masterfrom
thejohnlin:v3.0
Mar 25, 2015
Merged

V3.0: Removing explicit receiver for private method calls in VirtualServerUpgradeOrder(verify, place_order!)#90
SLsthompson merged 2 commits intosoftlayer:masterfrom
thejohnlin:v3.0

Conversation

@thejohnlin
Copy link
Copy Markdown

@thejohnlin thejohnlin commented Mar 24, 2015

In order to resolve a NoMethodError when placing or verifying a VirtualServerUpgradeOrder, I removed the "self" receivers from the verify, place_order!, and _item_price_with_capacity methods in VirtualServerUpgradeOrder.rb.

To reproduce, please review this sample:

vg_upgrade_order = SoftLayer::VirtualServerUpgradeOrder.new(vg)
vg_upgrade_order.ram = 4
vg_upgrade_order.place_order!

The stack dump is provided below:

c:/Ruby193/lib/ruby/gems/1.9.1/gems/softlayer_api-3.0.1/lib/softlayer/VirtualServerUpgradeOrder.rb:69:in `place_order!': private method `order_object' called for #<SoftLayer::VirtualServerUpgradeOrder:0x3cd2510> (NoMetho
dError)
        from c:/Users/IBM_ADMIN/workspace/john-v3-softlayer-api-wrapper_src/bin/sl_cli.rb:50:in `upgrade'
        from c:/Ruby193/lib/ruby/gems/1.9.1/gems/thor-0.19.1/lib/thor/command.rb:27:in `run'
        from c:/Ruby193/lib/ruby/gems/1.9.1/gems/thor-0.19.1/lib/thor/invocation.rb:126:in `invoke_command'
        from c:/Ruby193/lib/ruby/gems/1.9.1/gems/thor-0.19.1/lib/thor.rb:359:in `dispatch'
        from c:/Ruby193/lib/ruby/gems/1.9.1/gems/thor-0.19.1/lib/thor/invocation.rb:115:in `invoke'
        from c:/Ruby193/lib/ruby/gems/1.9.1/gems/thor-0.19.1/lib/thor.rb:235:in `block in subcommand'
        from c:/Ruby193/lib/ruby/gems/1.9.1/gems/thor-0.19.1/lib/thor/command.rb:27:in `run'
        from c:/Ruby193/lib/ruby/gems/1.9.1/gems/thor-0.19.1/lib/thor/invocation.rb:126:in `invoke_command'
        from c:/Ruby193/lib/ruby/gems/1.9.1/gems/thor-0.19.1/lib/thor.rb:359:in `dispatch'
        from c:/Ruby193/lib/ruby/gems/1.9.1/gems/thor-0.19.1/lib/thor/base.rb:440:in `start'
        from sl:4:in `<main>'

@coveralls
Copy link
Copy Markdown

coveralls commented Mar 24, 2015

Coverage Status

Coverage remained the same at 99.76% when pulling bd690a5 on thejohnlin:v3.0 into e045720 on softlayer:master.

1 similar comment
@coveralls
Copy link
Copy Markdown

coveralls commented Mar 24, 2015

Coverage Status

Coverage remained the same at 99.76% when pulling bd690a5 on thejohnlin:v3.0 into e045720 on softlayer:master.

SLsthompson added a commit that referenced this pull request Mar 25, 2015
@SLsthompson
Merge pull request #90 from thejohnlin/v3.0
bb909d6 
V3.0: Removing explicit receiver for private method calls in VirtualServerUpgradeOrder(verify, place_order!)
@SLsthompson SLsthompson merged commit bb909d6 into softlayer:master Mar 25, 2015
@thejohnlin thejohnlin deleted the v3.0 branch March 25, 2015 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@thejohnlin @coveralls @SLsthompson