Conversation
…JAK-57) - Replace 5 repetitive status-code tests in HttpMessageDelivererTest with a single withTests block using StatusCodeCase data class - Add withClue to ConcurrentClaimTests assertions for richer failure diagnostics (claimed set contents, DB state context)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
HttpMessageDelivererTestwith a singlewithTestsblock usingStatusCodeCasedata class (Kotest 6.x data-driven testing)withCluetoConcurrentClaimTestsassertions for richer failure diagnostics (claimed set contents, DB state context)Details
Kotest was already bumped from 5.9.1 → 6.1.10 by Dependabot. This PR completes the upgrade by adopting new Kotest 6.x features:
Data-driven testing (
HttpMessageDelivererTest):5 tests with identical structure (stub status code → assert result type) collapsed into one
withTestsblock. UsesStatusCodeCasedata class implementingWithDataTestNamefor stable test names.withClue(ConcurrentClaimTests):Concurrent test assertions now include diagnostic context (overlap IDs, claimed set sizes, DB state map) — critical for debugging non-deterministic race condition failures.
blockingTest— deliberately not adopted: analyzed all blocking test patterns;blockingTestonly affects the main test thread (not spawned threads), loses fast-fail semantics, and produces generic timeout errors instead of specific assertion failures.Test plan
okapi-core,okapi-http,okapi-kafka— 70 tests)