This repository was archived by the owner on Aug 31, 2022. It is now read-only.
Preliminary, work-in-progress SQLite support#79
Open
csachs wants to merge 4 commits intosorm:masterfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While I thought that development of SORM might be inactive, some recent commits have proven the opposite, so I'd like to propose another addition ...
I'm using SORM and I'm quite happy with it, but I would prefer to use SQLite over other embedded databases, as SQLite interoperability with other languages is much easier than e.g. H2.
Thus I've looked into adding SQLite support to SORM.
The patch so far passes many tests, however still has some weak spots:
I'm putting it here, as I guess it might already be in a state where it might be useful to others, and furthermore, some problems (like the DateTime serialization issue) might be much easier fixed if someone with more in-depth knowledge to SORM might take a look at it.
What do you think? I'll further take a look at the problems, but I'd be really happy if someone can point me to the right points; and afterwards this new database support could get added.
Best regards,
Christian