Replace build tool maven to sbt by takezoux2 · Pull Request #82 · sorm/sorm

takezoux2 · 2016-10-23T14:52:26Z

Replace scala versions to property in pom.xml
Append scala compat version to artifactId(It's a standard name rule for scala libraries)
Upgrade scala version to 2.11.8
Add build.sbt to also build by sbt
Remove 2.10.4 build in travis. Because scala 2.10.x build has already broken because of scala-logging.(Scala logging does not support scala 2.10.X)

Scala 2.12 coming soon.So should support multi scala versions.

And I have a question. .gitignore file is removed. What was wrong?

Support sbt build.

Remove 2.10 support because scala-logging does not support scala 2.10.X.

# Conflicts: # README.md # pom.xml

nikita-volkov · 2016-10-23T15:05:22Z

If you want to switch to SBT, you can just make the switch. Doubling of the project build files will prove to be a maintenance pain-point. Otherwise let it be Maven. All I'm asking is just to pick one.

And I have a question. .gitignore file is removed. What was wrong?

It's the developer's private thing, which environment he has, and hence which files to ignore. You can have your version of .gitignore on your machine and I'll have a different one on mine. The changes to it have nothing to do with the project.

To have .gitignore ignored by Git just mention it in itself or add it to your global list.

### ReflectionSuite.scala fix reflection name. ### FieldTestSuite1.scala Comment out oracle test. This test was skipped in maven test.

takezoux2 · 2016-10-23T17:33:53Z

.gitignore is normally shared by git.
Almost all projects share .gitignore. ex: https://github.com/scala/scala https://github.com/play/play https://github.com/scalaz/scalaz
Sharing .gitignore prevents miss adding. If you have your .gitignore, you should merge it.

SBT have a great advantage to cross build.
OK, l'll soon write sbt's pom generator.

nikita-volkov · 2016-10-23T18:01:50Z

Sharing .gitignore prevents miss adding.

It does not. It only prevents miss-adding of files, which are mentioned in it. The ones that aren't can still be added. To make your statement true, all the possible names, which don't relate to the project need to be mentioned. Which is kinda impossible.

A person is responsible for what he does, a committer is expected to review his commits.

I'm pretty sure you wouldn't be satisfied with one of the "gitignore" files that you've mentioned. So you'd be doing commits to that file. So, merges, discussions... All about what? Something that has zero value for the project.

So I've found it wisest to just keep out of this problem and hence keep it out of my projects. Trust me, once you'll add the ".gitignore" line to your local ".gitignore" file you'll forget we ever had this conversation.

SBT have a great advantage to cross build.

No problem. Switch to it, if you feel the need to.

OK, l'll soon write sbt's pom generator.

What?

Make to generate pom.xml by "sbt makePom" command

takezoux2 · 2016-11-20T14:16:33Z

Remove .gitignore and pom.xml.
But you can generate pom.xml by "sbt makePom".

pjfanning

Could you change the build.sbt common settings sorm version to 0.3.22-SNAPSHOT?
Also, could you change the sext version to 0.2.26.
I would also like to see the c3p0 dependency set to 0.9.2 instead of the current pre-release version.

pjfanning · 2016-12-07T12:37:40Z

  test("H2 initialization") { instance(DbType.H2).close() }
  test("MySQL initialization") { instance(DbType.Mysql).close() }
-  test("Oracle initialization") { instance(DbType.Oracle).close() }
+  //test("Oracle initialization") { instance(DbType.Oracle).close() }


Is there a reason to turn this part of test off?

Oracle tests ware broken, and I can't fix it because i'm not familiar with Oracle database.

pjfanning · 2016-12-07T12:38:40Z

@@ -0,0 +1,82 @@
+package sorm.macroimpl


If we don't continue to do sorm 2.10 builds, do we need this class?

pjfanning · 2016-12-07T12:40:09Z

+// Comment to get more information during initialization
+logLevel := Level.Warn
+
+addSbtPlugin("com.typesafe.sbt" % "sbt-pgp" % "0.8.3")


Could we look at using sbt-release plugin for publishing jars to maven repos? I use it in https://github.com/swagger-akka-http/swagger-akka-http and it is very effective.

pjfanning · 2016-12-08T18:07:59Z

@takezoux2 I did some testing of sorm 0.3.21 and found it only works in scala 2.11. It does look like for 2.12 support, we will need the cross compile support. What do you think it will take to get the sbt stuff merged?

pjfanning · 2016-12-20T13:22:54Z

I have pushed a sorm_2.12 to the sonatype snapshots repo, based on https://github.com/scala212-forks/sorm. This is just an interim solution.

0x6C38 · 2017-10-24T15:51:57Z

Any reason this hasn't been merged to master?

takezoux2 added 7 commits October 23, 2016 21:32

Append scala compat version.

c452335

Support sbt build.

Fix travis scala version

d775807

Make skip to test in travis build.

fc75c12

Move macro codes to each scala version directory.

3c70d5b

Remove 2.10 support because scala-logging does not support scala 2.10.X.

Merge branch 'master' into improve_build

6d50b1d

# Conflicts: # README.md # pom.xml

Fix library dependency.

391b9fc

Fix README.md

6484e3a

takezoux2 added 3 commits October 24, 2016 00:06

Update .travis.yml

918e31f

Disable parallel execution in test

94aad19

Fix to pass test.

e2fbe7c

### ReflectionSuite.scala fix reflection name. ### FieldTestSuite1.scala Comment out oracle test. This test was skipped in maven test.

takezoux2 added 2 commits November 20, 2016 22:59

remove .gitignore

e04fc02

Remove pom.xml

e8c9a03

Make to generate pom.xml by "sbt makePom" command

delete pom.xml

abbacfc

takezoux2 changed the title ~~Update maven project file to switch scala version.~~ Replace build tool maven to sbt Nov 28, 2016

pjfanning mentioned this pull request Dec 5, 2016

Scala 2.12 #84

Closed

pjfanning suggested changes Dec 7, 2016

View reviewed changes

pjfanning reviewed Dec 7, 2016

View reviewed changes

pjfanning pushed a commit to scala212-forks/sorm that referenced this pull request Dec 16, 2016

Use sbt build (based on takezoux2's pull request sorm#82)

810bd38

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Replace build tool maven to sbt#82

Replace build tool maven to sbt#82
takezoux2 wants to merge 13 commits intosorm:masterfrom
takezoux2:improve_build

takezoux2 commented Oct 23, 2016 •

edited

Loading

Uh oh!

nikita-volkov commented Oct 23, 2016

Uh oh!

takezoux2 commented Oct 23, 2016

Uh oh!

nikita-volkov commented Oct 23, 2016 •

edited

Loading

Uh oh!

takezoux2 commented Nov 20, 2016

Uh oh!

pjfanning left a comment

Uh oh!

pjfanning Dec 7, 2016

Uh oh!

takezoux2 Dec 8, 2016

Uh oh!

pjfanning Dec 7, 2016

Uh oh!

pjfanning Dec 7, 2016

Uh oh!

pjfanning commented Dec 8, 2016

Uh oh!

pjfanning commented Dec 20, 2016 •

edited

Loading

Uh oh!

0x6C38 commented Oct 24, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

takezoux2 commented Oct 23, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

nikita-volkov commented Oct 23, 2016

Uh oh!

takezoux2 commented Oct 23, 2016

Uh oh!

nikita-volkov commented Oct 23, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

takezoux2 commented Nov 20, 2016

Uh oh!

pjfanning left a comment

Choose a reason for hiding this comment

Uh oh!

pjfanning Dec 7, 2016

Choose a reason for hiding this comment

Uh oh!

takezoux2 Dec 8, 2016

Choose a reason for hiding this comment

Uh oh!

pjfanning Dec 7, 2016

Choose a reason for hiding this comment

Uh oh!

pjfanning Dec 7, 2016

Choose a reason for hiding this comment

Uh oh!

pjfanning commented Dec 8, 2016

Uh oh!

pjfanning commented Dec 20, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

0x6C38 commented Oct 24, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

takezoux2 commented Oct 23, 2016 •

edited

Loading

nikita-volkov commented Oct 23, 2016 •

edited

Loading

pjfanning commented Dec 20, 2016 •

edited

Loading