Merged
Conversation
umpox
approved these changes
May 4, 2022
umpox
reviewed
May 4, 2022
Co-authored-by: Tom Ross <[email protected]>
Merged
Member
Author
@umpox, what about Eunomia? 😃
Seriously speaking, I like the |
Contributor
|
Hah, I actually kinda like Eunomia! If we ever implement "chaos engineering" we'd have to have a repo called Dysnomia 😁 |
Member
Author
|
All-in Greek mythology! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Moving the
stylelint-pluginfrom the main Sourcegraph repo to leverage logic used for codemods later.This PR also introduces:
codemod/packages/stylelint-plugin/src/rules/filenames-match-regex/filenames-match-regex.ts
Lines 14 to 18 in 3c7e6e6
codemod/packages/stylelint-plugin/src/rules/no-restricted-imports/__tests__/no-restricted-imports.test.ts
Lines 3 to 38 in 3c7e6e6
stylelintpackage to the version used in the main Sourcegraph repo.no-restricted-importsrule that we can use to ban imports from packages that we want to migrate from. E.g.,bootstrap.codemod/packages/stylelint-plugin/src/rules/no-restricted-imports/no-restricted-imports.ts
Line 11 in 3c7e6e6
Integration plan
stylelint-pluginwill be published to NPM.Test plan
cd packages/stylelint-plugin && yarn linkcd main-sourcegraph-repo && yarn link "@sourcegraph/stylelint-plugin-sourcegraph"