feat: import the check-help-links ESLint rule#117
Merged
valerybugakov merged 1 commit intomainfrom May 6, 2022
Merged
Conversation
vovakulikov
approved these changes
May 6, 2022
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
This PR migrates the existing
check-help-linksESLint rule from the Sourcegraph repo to this one. The purpose of this work is to test the ESLint plugin integration. After that, the new custom rule will be added to this repo that will warn on the usage of specific React elements. E.g.,react/warn-elements.It's not currently possible to reuse the
react/forbid-elementsrule for warnings because of the limitations of the ESLint API. It would allow us to warn on the usage of patterns that we want to deprecate. E.g., while theInputmigration is not yet completed, we can ask engineers to use theInputcomponent over theinputelement today.Test plan
cd packages/eslint-plugin && yarn linkcd main-sourcegraph-repo && yarn link "@sourcegraph/eslint-plugin-sourcegraph"