feat: should download latest release on install by tjdevries · Pull Request #68 · sourcegraph/sg.nvim

tjdevries · 2023-08-04T19:46:36Z

No description provided.

skip-checks: true

tjdevries · 2023-08-08T15:13:59Z

@pjlast / @mrnugget could you give this a go? I think this is ready to go. You should be able to wipe out your target directory in your repo and then just download this branch and run the build step, and everything should work.

If so, I'll merge, then do a version bump and no more build step for users :) just a quick download step.

jamestrew · 2023-08-08T23:29:52Z

First time user trying out this branch - this might not be strictly related to this branch but I'm having issues with initial start up.

Stack trace

Failed to source `/home/jt/.local/share/nvim/lazy/sg.nvim/plugin/cody.lua`

vim/_editor.lua:0: /home/jt/.dotfiles/nvim/.config/nvim/init.lua..nvim_exec2() called at /home/jt/.dotfiles/nvim/.config/nvim/init.lua:0../home/jt/.local/share/nvim/lazy/sg.nvim/plugin/cody.lua: Vim(source):E5113: Error while calling lua chunk: /home/jt/.local/share/nvim/lazy/sg.nvim/lua/sg/rpc.lua:4: attempt to index a boolean value
stack traceback:
	/home/jt/.local/share/nvim/lazy/sg.nvim/lua/sg/rpc.lua:4: in main chunk
	[C]: in function 'require'
	...t/.local/share/nvim/lazy/sg.nvim/lua/sg/cody/context.lua:1: in main chunk
	[C]: in function 'require'
	...hare/nvim/lazy/sg.nvim/lua/sg/components/cody_layout.lua:11: in main chunk
	[C]: in function 'require'
	.../.local/share/nvim/lazy/sg.nvim/lua/sg/cody/commands.lua:10: in main chunk
	[C]: in function 'require'
	/home/jt/.local/share/nvim/lazy/sg.nvim/plugin/cody.lua:9: in main chunk
	[C]: in function 'nvim_exec2'
	vim/_editor.lua: in function 'cmd'
	...local/share/nvim/lazy/lazy.nvim/lua/lazy/core/loader.lua:467: in function <...local/share/nvim/lazy/lazy.nvim/lua/lazy/core/loader.lua:466>
	[C]: in function 'xpcall'
	.../.local/share/nvim/lazy/lazy.nvim/lua/lazy/core/util.lua:110: in function 'try'
	...local/share/nvim/lazy/lazy.nvim/lua/lazy/core/loader.lua:466: in function 'source'
	...local/share/nvim/lazy/lazy.nvim/lua/lazy/core/loader.lua:425: in function 'source_runtime'
	...local/share/nvim/lazy/lazy.nvim/lua/lazy/core/loader.lua:393: in function 'packadd'
	...local/share/nvim/lazy/lazy.nvim/lua/lazy/core/loader.lua:328: in function '_load'
	...local/share/nvim/lazy/lazy.nvim/lua/lazy/core/loader.lua:184: in function 'load'
	...local/share/nvim/lazy/lazy.nvim/lua/lazy/core/loader.lua:116: in function 'startup'
	/home/jt/.local/share/nvim/lazy/lazy.nvim/lua/lazy/init.lua:85: in function 'setup'
	/home/jt/.dotfiles/nvim/.config/nvim/init.lua:20: in main chunk

# stacktrace:
  - vim/_editor.lua:0 _in_ **cmd**
  - ~/.dotfiles/nvim/.config/nvim/init.lua:20


Failed to source `/home/jt/.local/share/nvim/lazy/sg.nvim/plugin/sg.lua`

vim/_editor.lua:0: /home/jt/.dotfiles/nvim/.config/nvim/init.lua..nvim_exec2() called at /home/jt/.dotfiles/nvim/.config/nvim/init.lua:0../home/jt/.local/share/nvim/lazy/sg.nvim/plugin/sg.lua: Vim(source):E5113: Error while calling lua chunk: /home/jt/.local/share/nvim/lazy/sg.nvim/lua/sg/bufread.lua:5: loop or previous error loading module 'sg.rpc'
stack traceback:
	[C]: in function 'require'
	/home/jt/.local/share/nvim/lazy/sg.nvim/lua/sg/bufread.lua:5: in main chunk
	[C]: in function 'require'
	/home/jt/.local/share/nvim/lazy/sg.nvim/plugin/sg.lua:9: in main chunk
	[C]: in function 'nvim_exec2'
	vim/_editor.lua: in function 'cmd'
	...local/share/nvim/lazy/lazy.nvim/lua/lazy/core/loader.lua:467: in function <...local/share/nvim/lazy/lazy.nvim/lua/lazy/core/loader.lua:466>
	[C]: in function 'xpcall'
	.../.local/share/nvim/lazy/lazy.nvim/lua/lazy/core/util.lua:110: in function 'try'
	...local/share/nvim/lazy/lazy.nvim/lua/lazy/core/loader.lua:466: in function 'source'
	...local/share/nvim/lazy/lazy.nvim/lua/lazy/core/loader.lua:425: in function 'source_runtime'
	...local/share/nvim/lazy/lazy.nvim/lua/lazy/core/loader.lua:393: in function 'packadd'
	...local/share/nvim/lazy/lazy.nvim/lua/lazy/core/loader.lua:328: in function '_load'
	...local/share/nvim/lazy/lazy.nvim/lua/lazy/core/loader.lua:184: in function 'load'
	...local/share/nvim/lazy/lazy.nvim/lua/lazy/core/loader.lua:116: in function 'startup'
	/home/jt/.local/share/nvim/lazy/lazy.nvim/lua/lazy/init.lua:85: in function 'setup'
	/home/jt/.dotfiles/nvim/.config/nvim/init.lua:20: in main chunk

# stacktrace:
  - vim/_editor.lua:0 _in_ **cmd**
  - ~/.dotfiles/nvim/.config/nvim/init.lua:20

require("sg.request") seems to be returning a boolean so require("sg.request").request is erroring out.

This is pre setting up sourcegraph login/auth via :SourceGraphLogin.
Trouble is, the SourceGraphLogin command fails to get created due to the error. Entirely possible this is user error but on the off chance it isn't, it's a bit of a catch 22 situation for new users.

mrnugget · 2023-08-09T14:14:33Z

@tjdevries works! I just wiped everything from disk, added plugin, PlugInstall, saw "Downloading binaries..." briefly

The only thing that confused me: I think I have to restart Vim after the installation for the Cody* commands to be registered

skip-checks: true

tjdevries · 2023-08-09T15:27:03Z

@jamestrew I pushed a new version of this, which should prevent the errors from happening.

Also though, it's :SourcegraphLogin not :SourceGraphLogin -- does the first command show up?

jamestrew

I think there's something sus happening around

sg.nvim/lua/sg/auth.lua

Lines 118 to 121 in 6138d65

    
           local cody_data = data.get_cody_data() 
        
           cody_data.token = data.token 
        
           cody_data.endpoint = data.endpoint 
        
           data.write_cody_data(cody_data)

I don't think the auth data is actually being saved correctly. So even though the SourcegraphLogin command shows up for me now (typo in my earlier comment), I still get caught on require("sg.request").request.

If I set up env variables for SRC_ENDPOINT, SRC_ACCESS_TOKEN, things look good though.
I do get some logging happening in the command line, but I take it that's just part of the pre-release nature of this plugin.

jamestrew · 2023-08-09T22:03:12Z

 ---@tag sg.rpc
 ---@config { ["module"] = "sg.rpc" }

+if not require "sg.request" then


Looks like with no login/auth, require "sg.request" is literally true so this condition will pass and still lead to the bad attribute access on line 8.

tjdevries · 2023-08-11T01:11:36Z

@jamestrew check last commit... haha i figured it out

tjdevries and others added 7 commits August 8, 2023 10:30

feat: should download latest release on install

6066e89

[docgen] Update doc/sg.txt

767e21e

skip-checks: true

ci: should try and build binaries

c35073e

ci: accept TOS

eca111a

some todos

ec4a452

fix: remove all external deps for build

1ba1635

add download binaries command

7fbfec2

tjdevries force-pushed the download-release branch from 268e722 to 7fbfec2 Compare August 8, 2023 14:31

tjdevries added 3 commits August 8, 2023 11:02

add health

c84b55e

version

ebe1244

update readme

8d76f30

tjdevries mentioned this pull request Aug 8, 2023

feat: optimize nix CI time + nix nvim integration test #53

Open

tjdevries and others added 2 commits August 9, 2023 11:26

fix: do less erroring when no auth and no setup

0441792

[docgen] Update doc/sg.txt

375e86b

skip-checks: true

jamestrew reviewed Aug 9, 2023

View reviewed changes

tjdevries added 2 commits August 10, 2023 21:09

update starting workflow

c170fd2

lol too many things named the same

7e669c3

better auth info in checkhealth

312eceb

tjdevries merged commit d8ddfc2 into master Aug 11, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: should download latest release on install#68

feat: should download latest release on install#68
tjdevries merged 15 commits intomasterfrom
download-release

tjdevries commented Aug 4, 2023

Uh oh!

tjdevries commented Aug 8, 2023

Uh oh!

jamestrew commented Aug 8, 2023

Uh oh!

mrnugget commented Aug 9, 2023

Uh oh!

tjdevries commented Aug 9, 2023

Uh oh!

jamestrew left a comment •

edited

Loading

Uh oh!

jamestrew Aug 9, 2023 •

edited

Loading

Uh oh!

tjdevries commented Aug 11, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

	local cody_data = data.get_cody_data()
	cody_data.token = data.token
	cody_data.endpoint = data.endpoint
	data.write_cody_data(cody_data)

Conversation

tjdevries commented Aug 4, 2023

Uh oh!

tjdevries commented Aug 8, 2023

Uh oh!

jamestrew commented Aug 8, 2023

Uh oh!

mrnugget commented Aug 9, 2023

Uh oh!

tjdevries commented Aug 9, 2023

Uh oh!

jamestrew left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jamestrew Aug 9, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

tjdevries commented Aug 11, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

jamestrew left a comment •

edited

Loading

jamestrew Aug 9, 2023 •

edited

Loading