This repository was archived by the owner on Sep 30, 2024. It is now read-only.
cmd/frontend/db: fix issue where JSONC was incorrectly treated as JSON (fixes #1540)#1714
Merged
cmd/frontend/db: fix issue where JSONC was incorrectly treated as JSON (fixes #1540)#1714
Conversation
fixes #1540) Prior to this change this code tried to treat JSONC as `json.RawMessage` but that is of course not legal because JSONC can contain comments, missing trailing commas, etc.
Member
Author
|
@nicksnyder I'll merge this now and follow up on any review comments you have (since I'd like to get this out asap) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prior to this change this code tried to treat JSONC as
json.RawMessagebutthat is of course not legal because JSONC can contain comments, missing trailing
commas, etc.