This repository was archived by the owner on Sep 30, 2024. It is now read-only.
Fix regressions in discussions#1850
Merged
francisschmaltz merged 2 commits intomasterfrom Jan 13, 2019
Merged
Conversation
emidoots
reviewed
Jan 13, 2019
emidoots
reviewed
Jan 13, 2019
| {node.title} | ||
| </a> | ||
| <small className="discussions-list__row-id">#{node.id}</small> | ||
| </h3> |
Member
There was a problem hiding this comment.
What is the motivation behind this change? I think if you click the ID, it should bring you to the actual item. That better drives home that the ID is the item, I think
Member
There was a problem hiding this comment.
Ah, hmm, I see you didn't change that and GitHub does the same, nevermind.
Codecov Report
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #1849
Fixes: #1847
Fixes: #1846
Also fixes odd light theme UI issues.