This repository was archived by the owner on Sep 30, 2024. It is now read-only.
web: move typography and button styles out from the .theme-redesign#22157
Merged
valerybugakov merged 8 commits intomainfrom Jul 19, 2021
Merged
web: move typography and button styles out from the .theme-redesign#22157valerybugakov merged 8 commits intomainfrom
.theme-redesign#22157valerybugakov merged 8 commits intomainfrom
Conversation
0c16a0b to
32a9e53
Compare
32a9e53 to
e987b81
Compare
Contributor
|
Notifying subscribers in CODENOTIFY files for diff fd661df...d500afd.
|
valerybugakov
commented
Jul 13, 2021
| } | ||
| return ( | ||
| <ButtonLink | ||
| className={classNames('btn btn-sm btn-outline-secondary nav-link text-decoration-none', props.className)} |
Member
Author
There was a problem hiding this comment.
The nav-link class is removed from here because it doesn't have any valuable styles, and before this PR, they were shadowed by the redesign button styles with higher specificity. This change keeps UI the same as it was before this PR.
vovakulikov
approved these changes
Jul 16, 2021
Contributor
vovakulikov
left a comment
There was a problem hiding this comment.
Good job with styles. Thanks!
5h1rU
approved these changes
Jul 16, 2021
Contributor
5h1rU
left a comment
There was a problem hiding this comment.
🎉
Can you change the PR name to web: move typography and buttons styles out from the .theme-redesign
.theme-redesign.theme-redesign
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
.theme-redesign..theme-redesignbecause they are connected to typography styles in the global scope.Notes
Moving redesign styles out from the
.theme-redesignclass resulted in multiple issues because the specificity of the selectors dropped. It's a good thing because, with Chromatic screenshots, I was able to fix changes that are inconsistent with the current design system and fix a couple of truly broken parts. Take a look into the changeset — things changed are actual inconsistencies that were hidden previously.Part of the https://github.com/sourcegraph/sourcegraph/issues/20847.
Closes https://github.com/sourcegraph/sourcegraph/issues/22597.
Closes https://github.com/sourcegraph/sourcegraph/issues/22598.