This repository was archived by the owner on Sep 30, 2024. It is now read-only.
Conversation
Contributor
|
Notifying subscribers in CODENOTIFY files for diff 76c4027...319c52e.
|
bobheadxi
reviewed
Jul 14, 2021
Comment on lines
+66
to
+67
| Warning: monitoring.Alert().GreaterOrEqual(10, nil).For(5 * time.Minute), | ||
| Critical: monitoring.Alert().GreaterOrEqual(20, nil).For(10 * time.Minute), |
Member
There was a problem hiding this comment.
I think this should be 10 and 20 milliseconds respectively, so in seconds it should be 0.01 and 0.02 right?
Contributor
There was a problem hiding this comment.
I think 5ms should be the warning threshold, and 10ms critical.
Contributor
Author
There was a problem hiding this comment.
Updated to be 5ms & 10ms
tsenart
approved these changes
Jul 14, 2021
tsenart
reviewed
Jul 16, 2021
| Warning: monitoring.Alert().GreaterOrEqual(0.05, nil).For(5 * time.Minute), | ||
| Critical: monitoring.Alert().GreaterOrEqual(0.10, nil).For(10 * time.Minute), | ||
| Owner: monitoring.ObservableOwnerCoreApplication, | ||
| PossibleSolutions: "none", |
Contributor
There was a problem hiding this comment.
Possible solution can actually be:
- Increase SRC_PGSQL_MAX_OPEN together with giving more memory to the database if needed.
- Scale up Postgres memory / cpus.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
During the incident today one key signal that would have been helpful was the mean db block time
This value surged during the incident and it would have been helpful to call this out.