This repository was archived by the owner on Sep 30, 2024. It is now read-only.
Merged
Conversation
Contributor
abeatrix
commented
Jul 15, 2021
Contributor
|
Notifying subscribers in CODENOTIFY files for diff c5dfdfe...b7a5a5d.
|
bobheadxi
reviewed
Jul 16, 2021
bobheadxi
reviewed
Jul 16, 2021
Member
bobheadxi
left a comment
There was a problem hiding this comment.
This is okay for now, but I feel like instrumentation should get a dedicated page about how to use it that notes that it is only available for Kubernetes deployments.
It would also be nice if we could hide this in the UI for non-kubernetes deployments... I'll take a look at that
bobheadxi
approved these changes
Jul 16, 2021
Co-authored-by: Robert Lin <[email protected]>
Contributor
Author
Agree. Or at least make it looks less... broken 😂 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.