Skip to content
This repository was archived by the owner on Sep 30, 2024. It is now read-only.

Code insights: Implement delete insights with new dashboard functionality #22886

Merged
vovakulikov merged 2 commits intomainfrom
code-insights/dashboard-delete-insight
Jul 16, 2021
Merged

Code insights: Implement delete insights with new dashboard functionality #22886
vovakulikov merged 2 commits intomainfrom
code-insights/dashboard-delete-insight

Conversation

@vovakulikov
Copy link
Copy Markdown
Contributor

@vovakulikov vovakulikov commented Jul 15, 2021 •
edited
Loading

Context

We always have this core insight functionality but with the dashboards system, we missed that at some point. This PR brings this functionality back. Currently, we have delete item in the insight context menu component. By click on that, you will delete this insight from all settings subjects and exclude this insight from all code insights dashboards.

image

Knowing issues

What have been done

  • Extract edit operations concept from the edit insight page
  • Re-write use-delete-insight handler taking into account new code insight dashboard system
  • Connect handler and UI

@vovakulikov vovakulikov added code-insights Issues related to the Code Insights product code-insights-dashboard labels Jul 15, 2021
@vovakulikov vovakulikov self-assigned this Jul 15, 2021
@sourcegraph-bot sourcegraph-bot mentioned this pull request Jul 15, 2021
Closed
24 tasks
@sourcegraph-bot sourcegraph-bot mentioned this pull request Jul 15, 2021
Closed
41 tasks
@vovakulikov vovakulikov marked this pull request as ready for review July 15, 2021 20:34
valerybugakov
valerybugakov approved these changes Jul 16, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@valerybugakov valerybugakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅

Comment thread client/web/src/insights/pages/insights/insights-page/hooks/delete-helpers.ts
Comment thread client/web/src/insights/core/settings-action/edits/apply-edit-operations.ts
@vovakulikov vovakulikov merged commit 9d7cbea into main Jul 16, 2021
@vovakulikov vovakulikov deleted the code-insights/dashboard-delete-insight branch July 16, 2021 07:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@tjkandala tjkandala Awaiting requested review from tjkandala

@eseliger eseliger Awaiting requested review from eseliger

1 more reviewer

@valerybugakov valerybugakov valerybugakov approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@vovakulikov vovakulikov

Labels

code-insights Issues related to the Code Insights product code-insights-dashboard

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@vovakulikov @valerybugakov