Skip to content
This repository was archived by the owner on Sep 30, 2024. It is now read-only.

doc: symlink CHANGELOG.md to docs for better search results#22918

Merged
bobheadxi merged 2 commits intomainfrom
changelog-in-docs
Jul 16, 2021
Merged

doc: symlink CHANGELOG.md to docs for better search results#22918
bobheadxi merged 2 commits intomainfrom
changelog-in-docs

Conversation

@bobheadxi
Copy link
Copy Markdown
Member

@bobheadxi bobheadxi commented Jul 16, 2021

Include CHANGELOG in the docsite, so as to surface changelog items while searching. Seems useful for figuring out when something was added/removed/fixed, as well as find things that might not really be documented anywhere else.

Playing around with some searches, this seems to be a really nice addition to results, and I don't think it introduces too much noise

Examples

What is instrumentation? Pretty much undocumented feature, but is in the changelog: it's a kubernetes feature!

image

The docs say to use this triggerObservabilityTestAlert, but I don't seem to have this functionality? In the changelog: added in 3.19!

image

What happened to experimentalFeatures.searchStreaming? Added in 3.25, removed in 3.29!

image

Full page

There is a caveat with this: anchor links for Added, Changed, etc. sections are suffixed with an index, and are thus not stable links. E.g. the 3.27.0 > Added link today is /CHANGELOG#added-3, but in a few releases this link will no longer point to 3.27.0.

image

@bobheadxi bobheadxi requested review from a team July 16, 2021 14:11
@sourcegraph-bot
Copy link
Copy Markdown
Contributor

sourcegraph-bot commented Jul 16, 2021

Notifying subscribers in CODENOTIFY files for diff 9f7ca9f...90bdb17.

Notify File(s)
@christinaforney doc/CHANGELOG.md
doc/index.md

@bobheadxi bobheadxi changed the title doc: symlink CHANGELOG.md to docsite for better changelog seach doc: symlink CHANGELOG.md to docsite for better search results Jul 16, 2021
@bobheadxi bobheadxi changed the title doc: symlink CHANGELOG.md to docsite for better search results doc: symlink CHANGELOG.md to docs for better search results Jul 16, 2021
Copy link
Copy Markdown

@chrislovett03 chrislovett03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thank you!

Copy link
Copy Markdown
Contributor

@abeatrix abeatrix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

brilliant! thank you robert!

@DaedalusG
Copy link
Copy Markdown
Contributor

Awesome!

@bobheadxi bobheadxi merged commit f641bd9 into main Jul 16, 2021
@bobheadxi bobheadxi deleted the changelog-in-docs branch July 16, 2021 15:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants