This repository was archived by the owner on Sep 30, 2024. It is now read-only.
repos: Don't cancel context on unauth / forbidden / accountsuspended#22947
Merged
repos: Don't cancel context on unauth / forbidden / accountsuspended#22947
Conversation
Cancelling that context eagerly means all follow up operations that use it will fail with context: canceled This also fixes the tests to actually catch this bug.
tsenart
added a commit
that referenced
this pull request
Jul 17, 2021
This commit makes the streaming syncer the default mode, while giving admins the option to disable it by setting the env var to false. We've been running this in production for about a week without any major problems apart from a small bug that only affected sourcegraph.com in practice (that was fixed in #22947). Making it the default will benefit large customers already and allow us to start deleting old code paths.
tsenart
pushed a commit
that referenced
this pull request
Jul 19, 2021
* repos: Make streaming syncer the default This commit makes the streaming syncer the default mode, while giving admins the option to disable it by setting the env var to false. We've been running this in production for about a week without any major problems apart from a small bug that only affected sourcegraph.com in practice (that was fixed in #22947). Making it the default will benefit large customers already and allow us to start deleting old code paths. * fixup! Update CHANGELOG
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cancelling that context eagerly means all follow up operations that use it will fail with context: canceled
This also fixes the tests to actually catch this bug. Saw this in https://sourcegraph.com/-/debug/proxies/repo-updater-10.164.5.144/debug/requests?fam=Store.DeleteExternalServiceReposNotIn&b=8&exp=1