This repository was archived by the owner on Sep 30, 2024. It is now read-only.
Code Insights: Fix the "loading Sourcegraph extensions" loading message for the dashboard page#22960
Merged
vovakulikov merged 1 commit intomainfrom Jul 19, 2021
Merged
Conversation
Contributor
Author
|
cc @AlicjaSuska @vovakulikov curious to know if you feel like it's good to show an "extensions" message on the insights page or if you're okay with this change? If there's a reason to have two separate error conditions I'm okay changing one of them slightly (we could make this one "loading code insights for this dashboard") just so we can tell them apart if a user reports them |
Contributor
|
@Joelkw I'm with you about this change. I added this thinking more about technical details rather than product aspects so I see you point and agree about stick with just loading code insights loading state. |
vovakulikov
approved these changes
Jul 19, 2021
Contributor
|
Thank you for bringing this up @Joelkw I agree as well |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I see you've got some great logic to check things, but every time I load the insights page I hit the "loading extensions." I think that's both confusing to a user and very much against our goal of abstracting away that these are powered by extensions (we want you to think of insights as a separate thing than extensions; we don't want you thinking insights is a subset feature of extensions, not the least because extensions may be available to all users on any plan and insights may not be someday).
I realize I'm just changing it to the message in the other condition. If you agree that it's confusing to show users this, perhaps we should collapse the conditions?
Loom: https://www.loom.com/share/cbbc9d922b3b46dea4e6242faaee7a37