This repository was archived by the owner on Sep 30, 2024. It is now read-only.
security: Log AccessGranted events when repo accessed directly#23168
Merged
security: Log AccessGranted events when repo accessed directly#23168
Conversation
Contributor
|
Notifying subscribers in CODENOTIFY files for diff 8aeec8c...b91355e.
|
unknwon
approved these changes
Jul 23, 2021
Contributor
Author
|
@unknwon Made a few more changes, PTAL |
unknwon
approved these changes
Jul 23, 2021
Contributor
Author
|
@unknwon Thanks. I'm going to hold off committing this until I'm back on Tuesday because there are currently some database issues and I don't want anything unexpected to happen over the weekend. |
efritz
pushed a commit
that referenced
this pull request
Jul 27, 2021
Log when a private repo is accessed directly. Also, instrument when a private repo is listed before deciding whether we should log it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Log AccessGranted event when private repo accessed
I added some instrumentation to see how often this happens, which right now is not a lot:
https://sourcegraph.com/-/debug/grafana/explore?orgId=1&left=%5B%22now-1h%22,%22now%22,%22Prometheus%22,%7B%22exemplar%22:true,%22expr%22:%22max(src_access_granted_private_repo)%22,%22requestId%22:%22Q-e60cde3b-6771-4b1e-b23c-196cc38600a3-0A%22%7D%5D
I've also added counter for where I plan to log events when listing repos