Skip to content
This repository was archived by the owner on Sep 30, 2024. It is now read-only.

extensibility: fix GitHub and GitLab hover overlay styles#23206

Merged
tjkandala merged 2 commits intomainfrom
tjk/gh-style-bext
Jul 26, 2021
Merged

extensibility: fix GitHub and GitLab hover overlay styles#23206
tjkandala merged 2 commits intomainfrom
tjk/gh-style-bext

Conversation

@tjkandala
Copy link
Copy Markdown
Contributor

Fix #23039.

Two style fixes in this PR:

  1. Button style fix: don't remove hover action border by default, only for web.
  2. Badge fix: move GitHub badge up to account for larger size.

Code hosts

GitHub

Before

Screenshot from 2021-07-25 17-29-56

After

Screenshot from 2021-07-25 17-28-58

GitLab

Before

Screenshot from 2021-07-25 16-47-47

After

Screenshot from 2021-07-25 16-47-01

Sourcegraph

Unchanged

Screenshot from 2021-07-25 17-37-41

@tjkandala tjkandala requested review from a team, valerybugakov and vovakulikov July 25, 2021 21:39
Copy link
Copy Markdown
Contributor

@Joelkw Joelkw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Visually, definitely an improvement!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Browser extension is not using github styles correctly

3 participants