This repository was archived by the owner on Sep 30, 2024. It is now read-only.
monitoring: Also show aggregate metrics if split via By#23237
Merged
Conversation
Contributor
|
Notifying subscribers in CODENOTIFY files for diff 9c1dd35...6d73d70.
|
bobheadxi
approved these changes
Jul 27, 2021
Member
bobheadxi
left a comment
There was a problem hiding this comment.
nice! with some thoughts 🤔 not blockers tho IMO (except for the enforcing By comment maybe, but that might just be too hard)
Member
|
Also, I'm rethinking the cosmetic appeal of Could we uppercase that and remove the brackets at some point, e.g. or even better, drop the |
Contributor
Author
|
@bobheadxi Updated if you want to take another look. I'll merge but if you have other suggestions I'll handle them in a follow-up PR. |
efritz
commented
Jul 27, 2021
efritz
commented
Jul 27, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates the
Observation.NewGroupconstructor to add an additional aggregate row that excludes theByfilter passed by the user when supplied. This allows engineers to quickly see the rate of individual types of requests if separated by a label.This also allows separate alerting on individual (any gitserver request) and aggregate requests (all gitserver requests).