Skip to content
This repository was archived by the owner on Sep 30, 2024. It is now read-only.

search: simplify repo rev callback resolution#23242

Merged
rvantonder merged 1 commit intomainfrom
backend-dry-run/rvt/simplify-callback
Jul 27, 2021
Merged

search: simplify repo rev callback resolution#23242
rvantonder merged 1 commit intomainfrom
backend-dry-run/rvt/simplify-callback

Conversation

@rvantonder
Copy link
Copy Markdown
Contributor

@rvantonder rvantonder commented Jul 26, 2021

Semantics preserving. See inline comments.

I'm looking at this code because I was wondering about a way to cleanly separate text and symbol matches (sendMatches tries to do too much disjoint stuff)

@sourcegraph-bot
Copy link
Copy Markdown
Contributor

Notifying subscribers in CODENOTIFY files for diff 61148fb...f3e84c2.

Notify File(s)
@beyang internal/search/zoekt/indexed_search.go
internal/search/zoekt/zoekt.go
@camdencheek internal/search/zoekt/indexed_search.go
internal/search/zoekt/zoekt.go
@keegancsmith internal/search/zoekt/indexed_search.go
internal/search/zoekt/zoekt.go

Comment thread internal/search/zoekt/indexed_search.go
@rvantonder rvantonder merged commit 88f2a40 into main Jul 27, 2021
@rvantonder rvantonder deleted the backend-dry-run/rvt/simplify-callback branch July 27, 2021 20:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants