This repository was archived by the owner on Sep 30, 2024. It is now read-only.
web: improve code block border consistency#23262
Merged
courier-new merged 1 commit intomainfrom Jul 28, 2021
Merged
Conversation
valerybugakov
approved these changes
Jul 27, 2021
Member
valerybugakov
left a comment
There was a problem hiding this comment.
Consistency 🚀
It would be nice to get 👀 from the @sourcegraph/design. We should consider updating the Wildcard sticker sheet similarly if it looks good from the design perspective.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR:
CodeSnippet, so that it matches the Monaco editorMonacoEditor, so that it matchesCodeSnippetI couldn't find evidence in the wildcard designs that this was intentional, so to me it seemed to make more sense with these changes.