Skip to content
This repository was archived by the owner on Sep 30, 2024. It is now read-only.

dotcom/productsubscription: allow SA to do license key lookup#54399

Merged
bobheadxi merged 1 commit intomainfrom
productsubscription-sa-get-licenses
Jun 28, 2023
Merged

dotcom/productsubscription: allow SA to do license key lookup#54399
bobheadxi merged 1 commit intomainfrom
productsubscription-sa-get-licenses

Conversation

@bobheadxi
Copy link
Copy Markdown
Member

@bobheadxi bobheadxi commented Jun 28, 2023

This is required for upcoming Cloud automation: https://github.com/sourcegraph/controller/pull/805

Currently we can't do the lookup:

ERROR mi2.instance.check.enforce.Enforce.cody mi2/instance.go:511 error encountered {"TraceId": "03e4d62c01a89c6a62e5d2e8f1cb6df6", "SpanId": "98bf6654fdf74de6", "environment": "prod", "instance": "src-96ed006bb45d673944e4", "error": "GetEmbeddingsIndexerToken: getSubscription: GetProductSubscriptionByLicense: input: dotcom.productLicenses must be site admin"}

Test plan

unit tests on the serviceAccountOrSiteAdmin helper

@bobheadxi bobheadxi requested review from a team and unknwon June 28, 2023 19:16
@cla-bot cla-bot Bot added the cla-signed label Jun 28, 2023
@bobheadxi bobheadxi enabled auto-merge (squash) June 28, 2023 19:16
@bobheadxi bobheadxi merged commit e13f032 into main Jun 28, 2023
@bobheadxi bobheadxi deleted the productsubscription-sa-get-licenses branch June 28, 2023 19:25
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants