This repository was archived by the owner on Sep 30, 2024. It is now read-only.
Merged
Conversation
lguychard
commented
Dec 17, 2019
attfarhan
approved these changes
Dec 18, 2019
Member
|
hmm are the e2e tests revealing a 2nd source of failure now? 🤔 |
Contributor
|
@eseliger I just hit rebuild, let's see if it happens again. It seems like it wasn't able to access localhost:7080 at all previously. |
eseliger
approved these changes
Dec 18, 2019
Member
|
not sure how the timeouts can happen but this seems to fix at least the biggest issue in e2e tests, great find :) |
Contributor
|
The e2e tests passed on rebuild. I think the initial failure was |
Contributor
|
Going to merge this since it has two approvals |
This was referenced Dec 18, 2019
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for https://github.com/sourcegraph/sourcegraph/issues/7212#issuecomment-566781691