Skip to content
This repository was archived by the owner on May 29, 2018. It is now read-only.

Add some comments#4

Merged
beyang merged 1 commit intomasterfrom
comments
Sep 18, 2014
Merged

Add some comments#4
beyang merged 1 commit intomasterfrom
comments

Conversation

@beyang
Copy link
Copy Markdown
Member

@beyang beyang commented Sep 17, 2014

Adding some comments testing my understanding of how this all works. Specific questions are marked with @sqs.

Btw, feature idea: it'd be really nice if I could just add a question on a specific function or line of code, so I didn't have to go through this routine

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

origins are the filenames that you want to emit defs from

it will analyze other files (for the purpose of type inference and refs) but only defs that are defined in an origin are emitted in the defs json

also refs are only emitted from origin files too

beyang added a commit that referenced this pull request Sep 18, 2014
@beyang beyang merged commit 7554607 into master Sep 18, 2014
@beyang beyang deleted the comments branch September 18, 2014 05:13
beyang added a commit that referenced this pull request Mar 5, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants