This repository was archived by the owner on May 29, 2018. It is now read-only.
Conversation
node_modules/jsg/bin/jsg
Outdated
Member
There was a problem hiding this comment.
origins are the filenames that you want to emit defs from
it will analyze other files (for the purpose of type inference and refs) but only defs that are defined in an origin are emitted in the defs json
also refs are only emitted from origin files too
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding some comments testing my understanding of how this all works. Specific questions are marked with @sqs.
Btw, feature idea: it'd be really nice if I could just add a question on a specific function or line of code, so I didn't have to go through this routine