This repository was archived by the owner on May 3, 2023. It is now read-only.
stop assuming always active window, fixes #15#45
Merged
beyang merged 1 commit intosourcegraph:masterfrom Aug 18, 2016
howeyc:nil-active
Merged
stop assuming always active window, fixes #15#45beyang merged 1 commit intosourcegraph:masterfrom howeyc:nil-active
beyang merged 1 commit intosourcegraph:masterfrom
howeyc:nil-active
Conversation
Member
|
thanks for this! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From what I can tell, there seems to be an implicit assumption that there will always be an "active" window. This is not the case, at least on windows (you could have everything minimized for example).
This fixes the issue in a quick and dirty way by making sure window returned from the map for the "active" window actually exists before trying to use the pointer.