This repository was archived by the owner on May 3, 2023. It is now read-only.
Start supporting more specific window title detection#75
Merged
beyang merged 4 commits intosourcegraph:masterfrom Sep 12, 2016
Merged
Start supporting more specific window title detection#75beyang merged 4 commits intosourcegraph:masterfrom
beyang merged 4 commits intosourcegraph:masterfrom
Conversation
This will leave the special cases for Google Chrome and Slack, but start getting granularity for free on windows that follow the general convention of ` - ` to separate out the application name at the end of the window title.
This will make it very easy to continue adding special cases for other applications
data.go
Outdated
| return w.IsSticky() || w.Desktop == desktop | ||
| } | ||
|
|
||
| const DefaultWindowTitleSeparator = " - " |
Member
There was a problem hiding this comment.
can you unexport these and use the following syntax:
const (
defaultWindowTitleSeparator = " - "
microsoftEdgeWindowTitleSeparator = "\u200e- "
)
Member
|
Thanks for submitting this, just one minor comment. Otherwise LGTM! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should help fix some of the windows in #73. On Win32, it handles every program I have. More detail and structure can continue to be added to support other conventions on other platforms.