Support file path (file:/) for download location regex#228
Merged
goneall merged 1 commit intospdx:masterfrom Mar 2, 2024
Merged
Support file path (file:/) for download location regex#228goneall merged 1 commit intospdx:masterfrom
goneall merged 1 commit intospdx:masterfrom
Conversation
goneall
approved these changes
Mar 2, 2024
Member
goneall
left a comment
There was a problem hiding this comment.
Thanks @vajain-1982
I check the spec and it does look like it supports any URL, so file:/ should be included.
Author
|
@goneall Thanks for merging , any idea when it will be available on maven central , I need to update spdx-gradle-plugin to consume this. |
Member
|
@vajain-1982 - I'll spin a release before the weekend - likely sooner. |
Member
|
@vajain-1982 - I just spun a new release - it should be available soon on Maven central. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support for files as part of download location
Currently regex defined for location validation doesn't allow for files
fixed updated the regex to include files
location example :- file:/Users/javarun/.m2/repository/jakarta/annotation/jakarta.annotation-api/2.1.1/jakarta.annotation-api-2.1.1.jar