Reforging LLaMA lobe (code from Samsung AI Center-Cambridge)#2850
Merged
Adel-Moumen merged 14 commits intospeechbrain:developfrom Apr 7, 2025
Merged
Reforging LLaMA lobe (code from Samsung AI Center-Cambridge)#2850Adel-Moumen merged 14 commits intospeechbrain:developfrom
Adel-Moumen merged 14 commits intospeechbrain:developfrom
Conversation
Adel-Moumen
reviewed
Mar 4, 2025
Collaborator
Author
|
@pplantinga do you have any idea why the doctest keep running on the llama file while I excluded it? This is frustrating ahah |
Collaborator
You need to add |
Collaborator
Author
|
@Adel-Moumen But like, isn't my change to the pytest file supposed to avoid testing llama.py? this sounds weird to me. |
Adel-Moumen
reviewed
Mar 24, 2025
Adel-Moumen
reviewed
Mar 28, 2025
pplantinga
pushed a commit
to pplantinga/speechbrain
that referenced
this pull request
Jun 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR refactor our LLaMA lobe to become generic enough and version agnostic. I cannot share the associated recipe for now, but it works ok. I still may have a few question open w.r.t checkpointing, but I think that this should be ok. I think that the current state of our LLaMA lobe is a real problem as it may hide the capacity of SB to adapt and to enable people to develop their custom code.
@poonehmousavi Multiwoz will need to be slightly refactor around this code I think. As a rule of thumb here are the potential changes:
To-do: