Skip to content

Change test for make_padding_mask to expose mistake#2895

Merged
pplantinga merged 2 commits intospeechbrain:developfrom
rogiervd:make_padding_mask-test-fix
May 21, 2025
Merged

Change test for make_padding_mask to expose mistake#2895
pplantinga merged 2 commits intospeechbrain:developfrom
rogiervd:make_padding_mask-test-fix

Conversation

@rogiervd
Copy link
Copy Markdown
Contributor

@rogiervd rogiervd commented May 2, 2025

What does this PR do?

I made a mistake in #2835 (comment). This is about masks for utterance given with fractional lengths in [0,1], and rounding errors.

I was right that 15/22*22 < 15, but that has no bearing on #2835.
What does have a bearing on it is that torch.tensor(7.)/13*13 > 7.

This test should start succeeding once I've fixed the bugs in #2894.

Before submitting
  • Did you read the contributor guideline?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Does your code adhere to project-specific code style and conventions?

PR review

Reviewer checklist
  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified
  • Confirm that the changes adhere to compatibility requirements (e.g., Python version, platform)
  • Review the self-review checklist to ensure the code is ready for review

@Adel-Moumen Adel-Moumen requested a review from pplantinga May 21, 2025 12:13
pplantinga
pplantinga approved these changes May 21, 2025
View reviewed changes
Copy link
Copy Markdown
Collaborator

@pplantinga pplantinga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pplantinga pplantinga merged commit 0ff5c0c into speechbrain:develop May 21, 2025
5 checks passed
pplantinga added a commit to pplantinga/speechbrain that referenced this pull request Jun 2, 2025
@rogiervd @pplantinga
Change test for make_padding_mask to expose mistake (speechbrain#2895)
4945dfc 
Co-authored-by: Rogier van Dalen <[email protected]>
Co-authored-by: Peter Plantinga <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pplantinga pplantinga pplantinga approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@rogiervd @pplantinga