Skip to content

Migrate to modern Python Logger API#2900

Merged
pplantinga merged 1 commit intospeechbrain:developfrom
emmanuel-ferdman:develop
May 16, 2025
Merged

Migrate to modern Python Logger API#2900
pplantinga merged 1 commit intospeechbrain:developfrom
emmanuel-ferdman:develop

Conversation

@emmanuel-ferdman
Copy link
Copy Markdown
Contributor

@emmanuel-ferdman emmanuel-ferdman commented May 12, 2025 •
edited
Loading

What does this PR do?

This small PR resolves the deprecation warnings of the logger library:

DeprecationWarning: The 'warn' method is deprecated, use 'warning' instead
Before submitting
  • Did you read the contributor guideline?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Does your code adhere to project-specific code style and conventions?

PR review

Reviewer checklist
  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified
  • Confirm that the changes adhere to compatibility requirements (e.g., Python version, platform)
  • Review the self-review checklist to ensure the code is ready for review

@emmanuel-ferdman
Migrate to modern Python Logger API
6d726ac 
Signed-off-by: Emmanuel Ferdman <[email protected]>
pplantinga
pplantinga approved these changes May 16, 2025
View reviewed changes
Copy link
Copy Markdown
Collaborator

@pplantinga pplantinga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pplantinga pplantinga merged commit 7d89773 into speechbrain:develop May 16, 2025
4 of 7 checks passed
pplantinga pushed a commit to pplantinga/speechbrain that referenced this pull request Jun 2, 2025
@emmanuel-ferdman @pplantinga
Migrate to modern Python Logger API (speechbrain#2900)
99340f2 
Signed-off-by: Emmanuel Ferdman <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pplantinga pplantinga pplantinga approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@emmanuel-ferdman @pplantinga