Skip to content

Fix bug constructing ValueError in Conv2d (from Samsung, AI Center, Cambridge)#2904

Merged
TParcollet merged 1 commit intospeechbrain:developfrom
rogiervd:pyright-cnn-valueerror
May 14, 2025
Merged

Fix bug constructing ValueError in Conv2d (from Samsung, AI Center, Cambridge)#2904
TParcollet merged 1 commit intospeechbrain:developfrom
rogiervd:pyright-cnn-valueerror

Conversation

@rogiervd
Copy link
Copy Markdown
Contributor

@rogiervd rogiervd commented May 13, 2025

What does this PR do?

This fixes a bug where a str is added to an int while constructing an error message.

I found this with Pyright (see #2901)

Before submitting
  • Did you read the contributor guideline?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Does your code adhere to project-specific code style and conventions?

PR review

Reviewer checklist
  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified
  • Confirm that the changes adhere to compatibility requirements (e.g., Python version, platform)
  • Review the self-review checklist to ensure the code is ready for review

@rogiervd rogiervd changed the title Fix bug constructing ValueError in Conv2d Fix bug constructing ValueError in Conv2d (from Samsung, AI Center, Cambridge) May 13, 2025
TParcollet
TParcollet approved these changes May 14, 2025
View reviewed changes
Copy link
Copy Markdown
Collaborator

@TParcollet TParcollet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@TParcollet TParcollet merged commit 20b18a0 into speechbrain:develop May 14, 2025
6 of 9 checks passed
pplantinga pushed a commit to pplantinga/speechbrain that referenced this pull request Jun 2, 2025
@rogiervd @pplantinga
Fix bug constructing ValueError in Conv2d (from Samsung, AI Center, C…
ef83cc6 
…ambridge) (speechbrain#2904)

Co-authored-by: Rogier van Dalen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TParcollet TParcollet TParcollet approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@rogiervd @TParcollet