Fix for Tracing ECAPA-TDNN Embedding Model#2982
Merged
TParcollet merged 2 commits intospeechbrain:developfrom Nov 2, 2025
Merged
Fix for Tracing ECAPA-TDNN Embedding Model#2982TParcollet merged 2 commits intospeechbrain:developfrom
TParcollet merged 2 commits intospeechbrain:developfrom
Conversation
…ther than attempting to pass lengths and checking for an exception
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Currently the
torch.onnx.exporttracer fails to export the ecapa-tdnn embedding model, giving the error described in #149760. This error occurs because an exception is part of the control flow of the model, used to check whether or not a given layer supports the length argument. When this is thrown, the tracer has already pushed the layer onto its stack so that, while the layer is not used, it sticks around until the end of the trace, where it is encountered instead of the root node, hence the key mismatch.The following very minimal code triggers the failure. I have also successfully exported the embedding model to onnx with the dynamo exporter, including dynamic batch and audio sample dimensions.
Fixes #149760
Before submitting
PR review
Reviewer checklist