Skip to content
This repository was archived by the owner on Jan 7, 2025. It is now read-only.

BatchAPI V2 Beta#65

Merged
teelisyys merged 7 commits intomasterfrom
feature/batchapiv2beta1
Mar 2, 2023
Merged

BatchAPI V2 Beta#65
teelisyys merged 7 commits intomasterfrom
feature/batchapiv2beta1

Conversation

@teelisyys
Copy link
Copy Markdown
Contributor

No description provided.

@teelisyys teelisyys force-pushed the feature/batchapiv2beta1 branch from a42f7e4 to d6aa578 Compare March 1, 2023 13:14
@teelisyys teelisyys force-pushed the feature/batchapiv2beta1 branch from 9eaaf3c to cfad3f1 Compare March 1, 2023 13:27
@teelisyys teelisyys enabled auto-merge (squash) March 1, 2023 14:07
}

// Describes the content of an audio as text.
message Transcript {
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe Transcript is unnecessary, as it only wrapped in OperationResult? Instead the Operation could include repeated OperationResult which could have ResultType instead of TranscriptType. This would make the result tree shallower and thus easier to understand.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added the OperationResult as it is expected that there will be result types that are sufficiently different from Transcript in the near future, so they can be added with only additive changes.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that would be possible also by extending the OperationResult itself, it could be just

message OperationResult {
  enum ResultType {
    ...
    RESULT_TYPE_TRANSCRIPT_LEXICAL = 1;
    ..
  }
  ResultType type = 1;
  string text = 2;
  repeated Token tokens = 3;
  // future additions here
  // repeated Event events = 4;
}

This would collect the result alternatives in the same type, instead of an additional intermediate container type.

@teelisyys teelisyys force-pushed the feature/batchapiv2beta1 branch from 52c415e to 9b3e657 Compare March 2, 2023 10:47
@teelisyys teelisyys merged commit c1c7a58 into master Mar 2, 2023
@teelisyys teelisyys deleted the feature/batchapiv2beta1 branch March 2, 2023 12:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants